[CLI-349] DefaultParser.parse() throws NullPointerException when options

parameter is null

- Fail faster using Objects.requireNonNull()

Author: garydgregory

src/changes/changes.xml

@@ -35,6 +35,7 @@
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Remove -nouses directive from maven-bundle-plugin. OSGi package imports now state 'uses' definitions for package imports, this doesn't affect JPMS (from org.apache.commons:commons-parent:80).</action>
       <action type="fix" dev="ggregory" due-to="Arnout Engelen">Deprecate PatternOptionBuilder.PatternOptionBuilder().</action>
       <action type="fix" issue="CLI-341" dev="ggregory" due-to="Ruiqi Dong, Gary Gregory">HelpFormatter infinite loop with 0 width input.</action>
+      <action type="fix" issue="CLI-349" dev="ggregory" due-to="Leo Fernandes, Gary Gregory">DefaultParser.parse() throws NullPointerException when options parameter is null.</action>
       <!-- ADD -->
       <action type="add" issue="CLI-339" dev="ggregory" due-to="Claude Warren, Gary Gregory">Help formatter extension in the new package #314.</action>
       <action type="add" dev="ggregory" due-to="Gary Gregory">CommandLine.Builder implements Supplier&lt;CommandLine&gt;.</action>

src/main/java/org/apache/commons/cli/DefaultParser.java

@@ -20,6 +20,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
 import java.util.ArrayList;
 import java.util.Enumeration;
 import java.util.List;
+import java.util.Objects;
 import java.util.Properties;
 import java.util.function.Consumer;
 import java.util.function.Supplier;
@@ -740,7 +741,7 @@ private boolean isShortOption(final String token) {
      */
     public CommandLine parse(final Options options, final Properties properties, final NonOptionAction nonOptionAction, final String... arguments)
             throws ParseException {
-        this.options = options;
+        this.options = Objects.requireNonNull(options, "options");
         this.nonOptionAction = nonOptionAction;
         skipParsing = false;
         currentOption = null;

src/test/java/org/apache/commons/cli/DefaultParserTest.java

@@ -394,6 +394,12 @@ void testParameterized(final String testName, final CommandLineParser parser, fi
         assertEquals(expected, cl.getOptionValue(option), message);
     }
 
+    @Test
+    void testParseNullOption() throws ParseException {
+        // Edge case
+        assertThrows(NullPointerException.class, () -> new DefaultParser().parse(null, null, DefaultParser.NonOptionAction.IGNORE, "-a"));
+    }
+
     @Override
     @Test
     @Disabled("Test case handled in the parameterized tests as \"DEFAULT behavior\"")