Rewrite DaitchMokotoffSoundex.soundex(String) using String.join()

garydgregory · garydgregory · commit 007ddf13798a · 2024-08-03T08:07:56.000-04:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -45,6 +45,7 @@ The <action> type attribute can be add,update,fix,remove.
   <body>
     <release version="1.17.2" date="YYYY-MM-DD" description="This is a feature and maintenance release. Java 8 or later is required.">
       <!-- FIX -->
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Rewrite DaitchMokotoffSoundex.soundex(String) using String.join().</action>
       <!-- ADD -->
       <!-- UPDATE -->
       <action type="update" dev="ggregory" due-to="Dependabot">Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 #296.</action>
diff --git a/src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java b/src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java
@@ -441,16 +441,7 @@ public String encode(final String source) {
      *             if a character is not mapped
      */
     public String soundex(final String source) {
-        final String[] branches = soundex(source, true);
-        final StringBuilder sb = new StringBuilder();
-        int index = 0;
-        for (final String branch : branches) {
-            sb.append(branch);
-            if (++index < branches.length) {
-                sb.append('|');
-            }
-        }
-        return sb.toString();
+        return String.join("|", soundex(source, true));
     }
 
     /**
