Skip to content

Commit 00ea5ee

Browse files
committed
Breaking binary compatibility should break the build instead of
generating a report one might skip reading, especially for PRs.
1 parent 9a39042 commit 00ea5ee

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

.github/workflows/maven.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,4 @@ jobs:
4545
with:
4646
java-version: ${{ matrix.java }}
4747
- name: Build with Maven
48-
run: mvn -V package --file pom.xml --no-transfer-progress
48+
run: mvn -V --file pom.xml --no-transfer-progress

pom.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,6 @@ limitations under the License.
246246
<checkstyle.version>2.17</checkstyle.version>
247247
<commons.japicmp.version>0.15.1</commons.japicmp.version>
248248
<commons.jacoco.version>0.8.6</commons.jacoco.version>
249-
250-
<!-- generate report even if there are binary incompatible changes -->
251-
<commons.japicmp.breakBuildOnBinaryIncompatibleModifications>false</commons.japicmp.breakBuildOnBinaryIncompatibleModifications>
252249
<japicmp.skip>false</japicmp.skip>
253250

254251
<!-- Commons Release Plugin -->
@@ -261,7 +258,7 @@ limitations under the License.
261258
<commons.releaseManagerKey>BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567</commons.releaseManagerKey>
262259
</properties>
263260
<build>
264-
<defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check javadoc:javadoc</defaultGoal>
261+
<defaultGoal>clean install apache-rat:check japicmp:cmp checkstyle:check javadoc:javadoc</defaultGoal>
265262
<pluginManagement>
266263
<plugins>
267264
<plugin>

0 commit comments

Comments
 (0)