Resolved FIXME comments: throw IAE when failed to parse resource files.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1379128 13f79535-47bb-0310-9956-ffa450edef68

Author: netomi

src/main/java/org/apache/commons/codec/language/bm/Lang.java

@@ -167,9 +167,8 @@ public static Lang loadFromResource(String languageRulesResourceName, Languages
                     String[] parts = line.split("\\s+");
 
                     if (parts.length != 3) {
-                        // FIXME: consider throwing an IllegalStateException like in Rule
-                        // System.err.println("Warning: malformed line '" + rawLine + "'");
-                        continue;
+                        throw new IllegalArgumentException("Malformed line '" + rawLine + "' in language resource '" +
+                                                           languageRulesResourceName + "'");
                     }
 
                     Pattern pattern = Pattern.compile(parts[0]);

src/main/java/org/apache/commons/codec/language/bm/Rule.java

@@ -358,18 +358,17 @@ private static List<Rule> parseRules(final Scanner scanner, final String locatio
                         // include statement
                         String incl = line.substring(HASH_INCLUDE.length()).trim();
                         if (incl.contains(" ")) {
-                            // FIXME: consider throwing an IllegalStateException like in parsePhonemeExpr
-                            // System.err.println("Warning: malformed import statement: " + rawLine);
+                            throw new IllegalArgumentException("Malformed import statement '" + rawLine + "' in " +
+                                                               location);
                         } else {
                             lines.addAll(parseRules(createScanner(incl), location + "->" + incl));
                         }
                     } else {
                         // rule
                         String[] parts = line.split("\\s+");
                         if (parts.length != 4) {
-                            // FIXME: consider throwing an IllegalStateException like in parsePhonemeExpr
-//                            System.err.println("Warning: malformed rule statement split into " + parts.length +
-//                                               " parts: " + rawLine);
+                            throw new IllegalArgumentException("Malformed rule statement split into " + parts.length +
+                                                               " parts: " + rawLine + " in " + location);
                         } else {
                             try {
                                 String pat = stripQuotes(parts[0]);
@@ -393,7 +392,8 @@ public String toString() {
                                 };
                                 lines.add(r);
                             } catch (IllegalArgumentException e) {
-                                throw new IllegalStateException("Problem parsing line " + currentLine, e);
+                                throw new IllegalStateException("Problem parsing line '" + currentLine + "' in " +
+                                                                location, e);
                             }
                         }
                     }