Use valid input for testing byte conversion, as behaviour for invalid input is undefined.

Fixes test failure with IBM Java 1.6

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1383170 13f79535-47bb-0310-9956-ffa450edef68

Author: sebbASF

src/test/java/org/apache/commons/codec/binary/StringUtilsTest.java

@@ -33,6 +33,12 @@ public class StringUtilsTest {
 
     private static final byte[] BYTES_FIXTURE = {'a','b','c'};
 
+    // This is valid input for UTF-16BE
+    private static final byte[] BYTES_FIXTURE_16BE = {0, 'a', 0, 'b', 0, 'c'};
+
+    // This is valid for UTF-16LE
+    private static final byte[] BYTES_FIXTURE_16LE = {'a', 0, 'b', 0, 'c', 0};
+
     private static final String STRING_FIXTURE = "ABC";
 
     /**
@@ -171,17 +177,17 @@ public void testNewStringUtf16() throws UnsupportedEncodingException {
     public void testNewStringUtf16Be() throws UnsupportedEncodingException {
         String charsetName = "UTF-16BE";
         testNewString(charsetName);
-        String expected = new String(BYTES_FIXTURE, charsetName);
-        String actual = StringUtils.newStringUtf16Be(BYTES_FIXTURE);
+        String expected = new String(BYTES_FIXTURE_16BE, charsetName);
+        String actual = StringUtils.newStringUtf16Be(BYTES_FIXTURE_16BE);
         Assert.assertEquals(expected, actual);
     }
 
     @Test
     public void testNewStringUtf16Le() throws UnsupportedEncodingException {
         String charsetName = "UTF-16LE";
         testNewString(charsetName);
-        String expected = new String(BYTES_FIXTURE, charsetName);
-        String actual = StringUtils.newStringUtf16Le(BYTES_FIXTURE);
+        String expected = new String(BYTES_FIXTURE_16LE, charsetName);
+        String actual = StringUtils.newStringUtf16Le(BYTES_FIXTURE_16LE);
         Assert.assertEquals(expected, actual);
     }