Deprecate BaseNCodec.isWhiteSpace(byte) and use

Character.isWhitespace(int)

Author: garydgregory

src/changes/changes.xml

@@ -57,6 +57,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action                   dev="kinow" type="fix" due-to="Marc Wrobel">Fix several typos, improve writing in some javadocs #139.</action>
       <action                   dev="ggregory" type="fix" due-to="Gary Gregory">BaseNCodecOutputStream.eof() should not throw IOException.</action>
       <action                   dev="ggregory" type="fix" due-to="Gary Gregory">Javadoc improvements and cleanups.</action>
+      <action                   dev="ggregory" type="fix" due-to="Gary Gregory">Deprecate BaseNCodec.isWhiteSpace(byte) and use Character.isWhitespace(int).</action>
       <!-- ADD -->
       <action issue="CODEC-296" dev="mattsicker" type="add" due-to="Matt Sicker">Add support for Blake3 family of hashes.</action>
       <action                   dev="ggregory" type="add">Add github/codeql-action.</action>

src/main/java/org/apache/commons/codec/binary/Base32.java

@@ -335,7 +335,7 @@ public Base32(final int lineLength, final byte[] lineSeparator, final boolean us
         }
         this.decodeSize = this.encodeSize - 1;
 
-        if (isInAlphabet(padding) || isWhiteSpace(padding)) {
+        if (isInAlphabet(padding) || Character.isWhitespace(padding)) {
             throw new IllegalArgumentException("pad must not be in alphabet or whitespace");
         }
     }

src/main/java/org/apache/commons/codec/binary/Base64.java

@@ -389,7 +389,7 @@ public static boolean isBase64(final byte octet) {
      */
     public static boolean isBase64(final byte[] arrayOctet) {
         for (final byte element : arrayOctet) {
-            if (!isBase64(element) && !isWhiteSpace(element)) {
+            if (!isBase64(element) && !Character.isWhitespace(element)) {
                 return false;
             }
         }

src/main/java/org/apache/commons/codec/binary/BaseNCodec.java

@@ -277,21 +277,15 @@ public static byte[] getChunkSeparator() {
 
     /**
      * Checks if a byte value is whitespace or not.
-     * Whitespace is taken to mean: space, tab, CR, LF
      * @param byteToCheck
      *            the byte to check
      * @return true if byte is whitespace, false otherwise
+     * @see Character#isWhitespace(int)
+     * @deprecated Use {@link Character#isWhitespace(int)}.
      */
+    @Deprecated
     protected static boolean isWhiteSpace(final byte byteToCheck) {
-        switch (byteToCheck) {
-            case ' ' :
-            case '\n' :
-            case '\r' :
-            case '\t' :
-                return true;
-            default :
-                return false;
-        }
+        return Character.isWhitespace(byteToCheck);
     }
 
     /**
@@ -641,7 +635,7 @@ boolean hasData(final Context context) {  // package protected for access from I
     public boolean isInAlphabet(final byte[] arrayOctet, final boolean allowWSPad) {
         for (final byte octet : arrayOctet) {
             if (!isInAlphabet(octet) &&
-                    (!allowWSPad || (octet != pad) && !isWhiteSpace(octet))) {
+                    (!allowWSPad || (octet != pad) && !Character.isWhitespace(octet))) {
                 return false;
             }
         }

src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java

@@ -105,10 +105,16 @@ public void testBaseNCodec() {
 //
     @Test
     public void testIsWhiteSpace() {
-        assertTrue(BaseNCodec.isWhiteSpace((byte) ' '));
-        assertTrue(BaseNCodec.isWhiteSpace((byte) '\n'));
-        assertTrue(BaseNCodec.isWhiteSpace((byte) '\r'));
-        assertTrue(BaseNCodec.isWhiteSpace((byte) '\t'));
+        assertTrue(Character.isWhitespace((byte) ' '));
+        assertTrue(Character.isWhitespace((byte) '\n'));
+        assertTrue(Character.isWhitespace((byte) '\r'));
+        assertTrue(Character.isWhitespace((byte) '\t'));
+        assertTrue(Character.isWhitespace((byte) '\f'));
+        assertTrue(Character.isWhitespace((byte) '\u000B'));
+        for (byte b = Byte.MIN_VALUE; b < Byte.MAX_VALUE; b++) {
+            final byte byteToCheck = b;
+            assertEquals(Character.isWhitespace(b), Character.isWhitespace(byteToCheck));
+        }
     }
 //
 //    @Test