Skip to content

Commit 263fc19

Browse files
committed
[CODEC-209] Javadoc for SHA-224 DigestUtils methods should mention Java 1.8.0 restriction instead of 1.4.0.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1743772 13f79535-47bb-0310-9956-ffa450edef68
1 parent 4970841 commit 263fc19

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

src/changes/changes.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
4646
<action dev="sebb" type="fix" issue="CODEC-200" due-to="Luciano Vernaschi">Base32.HEX_DECODE_TABLE contains the wrong value 32</action>
4747
<action dev="ggregory" type="fix" issue="CODEC-207" due-to="Gary Gregory">Charsets Javadoc breaks build when using Java 8</action>
4848
<action dev="ggregory" type="fix" issue="CODEC-199" due-to="Yossi Tamari">Bug in HW rule in Soundex</action>
49+
<action dev="ggregory" type="fix" issue="CODEC-209" due-to="Gary Gregory">Javadoc for SHA-224 DigestUtils methods should mention Java 1.8.0 restriction instead of 1.4.0.</action>
4950
<action dev="ggregory" type="add" issue="CODEC-208" due-to="Gary Gregory">Make some DigestUtils APIs public</action>
5051
<action dev="ggregory" type="add" issue="CODEC-206" due-to="Gary Gregory">Add java.io.File APIs to DigestUtils</action>
5152
<action dev="ggregory" type="add" issue="CODEC-183" due-to="Steven Wurster">BaseNCodecOutputStream only supports writing EOF on close()</action>

src/main/java/org/apache/commons/codec/digest/DigestUtils.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -703,14 +703,15 @@ public static byte[] sha224(final ByteBuffer data) {
703703
/**
704704
* Calculates the SHA-224 digest and returns the value as a <code>byte[]</code>.
705705
* <p>
706-
* Throws a <code>RuntimeException</code> on JRE versions prior to 1.4.0.
706+
* Throws a <code>RuntimeException</code> on JRE versions prior to 1.8.0.
707707
* </p>
708708
*
709709
* @param data
710710
* File to digest
711711
* @return SHA-224 digest
712712
* @throws IOException
713713
* On error reading from the stream
714+
* @throws IllegalArgumentException thrown on JRE versions prior to 1.8.0.
714715
* @since 1.11
715716
*/
716717
public static byte[] sha224(final File data) throws IOException {
@@ -720,7 +721,7 @@ public static byte[] sha224(final File data) throws IOException {
720721
/**
721722
* Calculates the SHA-224 digest and returns the value as a <code>byte[]</code>.
722723
* <p>
723-
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.4.0.
724+
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.8.0.
724725
* </p>
725726
*
726727
* @param data
@@ -738,7 +739,7 @@ public static byte[] sha224(final InputStream data) throws IOException {
738739
/**
739740
* Calculates the SHA-224 digest and returns the value as a <code>byte[]</code>.
740741
* <p>
741-
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.4.0.
742+
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.8.0.
742743
* </p>
743744
*
744745
* @param data
@@ -754,7 +755,7 @@ public static byte[] sha224(final String data) {
754755
/**
755756
* Calculates the SHA-224 digest and returns the value as a hex string.
756757
* <p>
757-
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.4.0.
758+
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.8.0.
758759
* </p>
759760
*
760761
* @param data
@@ -770,7 +771,7 @@ public static String sha224Hex(final byte[] data) {
770771
/**
771772
* Calculates the SHA-224 digest and returns the value as a hex string.
772773
* <p>
773-
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.4.0.
774+
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.8.0.
774775
* </p>
775776
*
776777
* @param data
@@ -786,7 +787,7 @@ public static String sha224Hex(final ByteBuffer data) {
786787
/**
787788
* Calculates the SHA-224 digest and returns the value as a hex string.
788789
* <p>
789-
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.4.0.
790+
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.8.0.
790791
* </p>
791792
*
792793
* @param data
@@ -804,7 +805,7 @@ public static String sha224Hex(final File data) throws IOException {
804805
/**
805806
* Calculates the SHA-224 digest and returns the value as a hex string.
806807
* <p>
807-
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.4.0.
808+
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.8.0.
808809
* </p>
809810
*
810811
* @param data
@@ -822,7 +823,7 @@ public static String sha224Hex(final InputStream data) throws IOException {
822823
/**
823824
* Calculates the SHA-224 digest and returns the value as a hex string.
824825
* <p>
825-
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.4.0.
826+
* Throws a {@link IllegalArgumentException} on JRE versions prior to 1.8.0.
826827
* </p>
827828
*
828829
* @param data

0 commit comments

Comments
 (0)