Skip to content

Commit 3077398

Browse files
committed
Replace StringBuffer with non-synch Builder
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1333715 13f79535-47bb-0310-9956-ffa450edef68
1 parent 07cf4e9 commit 3077398

7 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/test/java/org/apache/commons/codec/binary/Base64Test.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ public void testDecodeWithWhitespace() throws Exception {
289289
String orig = "I am a late night coder.";
290290

291291
byte[] encodedArray = Base64.encodeBase64(orig.getBytes(Charsets.UTF_8));
292-
StringBuffer intermediate = new StringBuffer(new String(encodedArray));
292+
StringBuilder intermediate = new StringBuilder(new String(encodedArray));
293293

294294
intermediate.insert(2, ' ');
295295
intermediate.insert(5, '\t');
@@ -1208,7 +1208,7 @@ public void testStringToByteVariations() throws DecoderException {
12081208
}
12091209

12101210
private String toString(byte[] data) {
1211-
StringBuffer buf = new StringBuffer();
1211+
StringBuilder buf = new StringBuilder();
12121212
for (int i = 0; i < data.length; i++) {
12131213
buf.append(data[i]);
12141214
if (i != data.length - 1) {

src/test/java/org/apache/commons/codec/language/DoubleMetaphoneTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1172,8 +1172,8 @@ public void testIsDoubleMetaphoneEqualExtended2() {
11721172
@Test
11731173
public void testIsDoubleMetaphoneEqualExtended3() {
11741174
this.validateFixture(FIXTURE);
1175-
StringBuffer failures = new StringBuffer();
1176-
StringBuffer matches = new StringBuffer();
1175+
StringBuilder failures = new StringBuilder();
1176+
StringBuilder matches = new StringBuilder();
11771177
String cr = System.getProperty("line.separator");
11781178
matches.append("private static final String[][] MATCHES = {" + cr);
11791179
int failCount = 0;

src/test/java/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ public void testSetRuleTypeToRulesIllegalArgumentException() {
190190
@Test(/* timeout = 20000L */)
191191
public void testSpeedCheck() throws EncoderException {
192192
BeiderMorseEncoder bmpm = this.createGenericApproxEncoder();
193-
StringBuffer stringBuffer = new StringBuffer();
193+
StringBuilder stringBuffer = new StringBuilder();
194194
stringBuffer.append(TEST_CHARS[0]);
195195
for (int i = 0, j = 1; i < 40; i++, j++) {
196196
if (j == TEST_CHARS.length) {

src/test/java/org/apache/commons/codec/net/BCodecTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public class BCodecTest {
4242
{ 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 };
4343

4444
private String constructString(int[] unicodeChars) {
45-
StringBuffer buffer = new StringBuffer();
45+
StringBuilder buffer = new StringBuilder();
4646
if (unicodeChars != null) {
4747
for (int unicodeChar : unicodeChars) {
4848
buffer.append((char) unicodeChar);

src/test/java/org/apache/commons/codec/net/QCodecTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public class QCodecTest {
4848
};
4949

5050
private String constructString(int [] unicodeChars) {
51-
StringBuffer buffer = new StringBuffer();
51+
StringBuilder buffer = new StringBuilder();
5252
if (unicodeChars != null) {
5353
for (int unicodeChar : unicodeChars) {
5454
buffer.append((char)unicodeChar);

src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public class QuotedPrintableCodecTest {
4747
};
4848

4949
private String constructString(int [] unicodeChars) {
50-
StringBuffer buffer = new StringBuffer();
50+
StringBuilder buffer = new StringBuilder();
5151
if (unicodeChars != null) {
5252
for (int unicodeChar : unicodeChars) {
5353
buffer.append((char)unicodeChar);

src/test/java/org/apache/commons/codec/net/URLCodecTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ private void validateState(URLCodec urlCodec) {
5050
}
5151

5252
private String constructString(int [] unicodeChars) {
53-
StringBuffer buffer = new StringBuffer();
53+
StringBuilder buffer = new StringBuilder();
5454
if (unicodeChars != null) {
5555
for (int unicodeChar : unicodeChars) {
5656
buffer.append((char)unicodeChar);

0 commit comments

Comments
 (0)