We could make the constructor private but there does not seem to be a point to jumping through extra code hoops to restrict instantiation right now.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@798339 13f79535-47bb-0310-9956-ffa450edef68

Author: garydgregory

src/java/org/apache/commons/codec/binary/StringUtils.java

@@ -270,7 +270,4 @@ public static String newStringUtf8(byte[] bytes) {
         return StringUtils.newString(bytes, CharEncoding.UTF_8);
     }
 
-    private StringUtils() {
-        // noop, cannot instantiate. Can always relax later.
-    }
 }

src/test/org/apache/commons/codec/binary/StringUtilsTest.java

@@ -32,6 +32,7 @@ public class StringUtilsTest extends TestCase {
     private static byte[] BYTES_FIXTURE;
 
     private static final String STRING_FIXTURE = "ABC";
+
     {
         try {
             BYTES_FIXTURE = "abc".getBytes("US-ASCII");
@@ -40,6 +41,14 @@ public class StringUtilsTest extends TestCase {
         }
     }
 
+    /**
+     * We could make the constructor private but there does not seem to be a point to jumping through extra code hoops
+     * to restrict instantiation right now.
+     */
+    public void testConstructor() {
+        new StringUtils();
+    }
+
     public void testGetBytesIso8859_1() throws UnsupportedEncodingException {
         String charsetName = "ISO-8859-1";
         testGetSupportedBytes(charsetName);
@@ -165,5 +174,4 @@ public void testNewStringUtf8() throws UnsupportedEncodingException {
         String actual = StringUtils.newStringUtf8(BYTES_FIXTURE);
         Assert.assertEquals(expected, actual);
     }
-
 }