Refactor API calls in lvar.

garydgregory · garydgregory · commit 40a63e663cae · 2014-04-10T12:51:29.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1586286 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/codec/language/Metaphone.java b/src/main/java/org/apache/commons/codec/language/Metaphone.java
@@ -91,11 +91,12 @@ public Metaphone() {
      */
     public String metaphone(final String txt) {
         boolean hard = false;
-        if (txt == null || txt.length() == 0) {
+        final int txtLength = txt.length();
+        if (txt == null || txtLength == 0) {
             return "";
         }
         // single character is itself
-        if (txt.length() == 1) {
+        if (txtLength == 1) {
             return txt.toUpperCase(java.util.Locale.ENGLISH);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -91,11 +91,12 @@ public Metaphone() {`
`91`	`91`	`*/`
`92`	`92`	`public String metaphone(final String txt) {`
`93`	`93`	`boolean hard = false;`
`94`		`- if (txt == null \|\| txt.length() == 0) {`
	`94`	`+ final int txtLength = txt.length();`
	`95`	`+ if (txt == null \|\| txtLength == 0) {`
`95`	`96`	`return "";`
`96`	`97`	`}`
`97`	`98`	`// single character is itself`
`98`		`- if (txt.length() == 1) {`
	`99`	`+ if (txtLength == 1) {`
`99`	`100`	`return txt.toUpperCase(java.util.Locale.ENGLISH);`
`100`	`101`	`}`
`101`	`102`