Pull-up common Builder attribute to BaseNCodec

Author: garydgregory

src/main/java/org/apache/commons/codec/binary/Base32.java

@@ -49,9 +49,6 @@ public class Base32 extends BaseNCodec {
      */
     public static class Builder extends AbstractBuilder<Base32, Builder> {
 
-        /** Padding byte. */
-        private byte padding = PAD_DEFAULT;
-
         /**
          * Constructs a new instance.
          */
@@ -61,18 +58,7 @@ public Builder() {
 
         @Override
         public Base32 get() {
-            return new Base32(getLineLength(), getLineSeparator(), getEncodeTable(), padding, getDecodingPolicy());
-        }
-
-        /**
-         * Sets the padding byte.
-         *
-         * @param padding the padding byte.
-         * @return this.
-         */
-        public Builder setPadding(final byte padding) {
-            this.padding = padding;
-            return this;
+            return new Base32(getLineLength(), getLineSeparator(), getEncodeTable(), getPadding(), getDecodingPolicy());
         }
 
     }

src/main/java/org/apache/commons/codec/binary/BaseNCodec.java

@@ -66,7 +66,8 @@ public abstract static class AbstractBuilder<T, B extends AbstractBuilder<T, B>>
         private byte[] lineSeparator = CHUNK_SEPARATOR;
         private final byte[] defaultEncodeTable;
         private byte[] encodeTable;
-
+        /** Padding byte. */
+        private byte padding = PAD_DEFAULT;
 
         AbstractBuilder(final byte[] defaultEncodeTable) {
             this.defaultEncodeTable = defaultEncodeTable;
@@ -94,6 +95,10 @@ byte[] getLineSeparator() {
             return lineSeparator;
         }
 
+        byte getPadding() {
+            return padding;
+        }
+
         /**
          * Sets the decoding policy.
          *
@@ -138,6 +143,17 @@ public B setLineSeparator(final byte... lineSeparator) {
             return asThis();
         }
 
+        /**
+         * Sets the padding byte.
+         *
+         * @param padding the padding byte.
+         * @return this.
+         */
+        public B setPadding(final byte padding) {
+            this.padding = padding;
+            return asThis();
+        }
+
     }
 
     /**