Normalize array type declarations

Author: garydgregory

src/test/java/org/apache/commons/codec/binary/Base16Test.java

@@ -278,7 +278,7 @@ public void testPairs() {
         assertEquals("0010", new String(new Base16().encode(new byte[] { (byte) 0, (byte) 16 })));
         assertEquals("0011", new String(new Base16().encode(new byte[] { (byte) 0, (byte) 17 })));
         for (int i = -128; i <= 127; i++) {
-            final byte test[] = { (byte) i, (byte) i };
+            final byte[] test = { (byte) i, (byte) i };
             assertArrayEquals(test, new Base16().decode(new Base16().encode(test)));
         }
     }
@@ -391,7 +391,7 @@ public void testSingletons() {
         assertEquals("67", new String(new Base16().encode(new byte[] { (byte) 103 })));
         assertEquals("68", new String(new Base16().encode(new byte[] { (byte) 104 })));
         for (int i = -128; i <= 127; i++) {
-            final byte test[] = { (byte) i };
+            final byte[] test = { (byte) i };
             assertArrayEquals(test, new Base16().decode(new Base16().encode(test)));
         }
     }

src/test/java/org/apache/commons/codec/binary/Base32Test.java

@@ -365,14 +365,14 @@ public void testSingleCharEncoding() {
         for (int i = 0; i < 20; i++) {
             Base32 codec = new Base32();
             final BaseNCodec.Context context = new BaseNCodec.Context();
-            final byte unencoded[] = new byte[i];
-            final byte allInOne[] = codec.encode(unencoded);
+            final byte[] unencoded = new byte[i];
+            final byte[] allInOne = codec.encode(unencoded);
             codec = new Base32();
             for (int j=0; j< unencoded.length; j++) {
                 codec.encode(unencoded, j, 1, context);
             }
             codec.encode(unencoded, 0, -1, context);
-            final byte singly[] = new byte[allInOne.length];
+            final byte[] singly = new byte[allInOne.length];
             codec.readResults(singly, 0, 100, context);
             if (!Arrays.equals(allInOne, singly)){
                 fail();

src/test/java/org/apache/commons/codec/binary/Base64Test.java

@@ -588,7 +588,7 @@ public void testObjectEncode() throws Exception {
     public void testPairs() {
         assertEquals("AAA=", new String(Base64.encodeBase64(new byte[] { 0, 0 })));
         for (int i = -128; i <= 127; i++) {
-            final byte test[] = { (byte) i, (byte) i };
+            final byte[] test = { (byte) i, (byte) i };
             assertArrayEquals(test, Base64.decodeBase64(Base64.encodeBase64(test)));
         }
     }
@@ -868,7 +868,7 @@ public void testSingletons() {
         assertEquals("Zw==", new String(Base64.encodeBase64(new byte[] { (byte) 103 })));
         assertEquals("aA==", new String(Base64.encodeBase64(new byte[] { (byte) 104 })));
         for (int i = -128; i <= 127; i++) {
-            final byte test[] = { (byte) i };
+            final byte[] test = { (byte) i };
             assertArrayEquals(test, Base64.decodeBase64(Base64.encodeBase64(test)));
         }
     }

src/test/java/org/apache/commons/codec/binary/HexTest.java

@@ -530,7 +530,7 @@ public void testEncodeHex_ByteBufferWithLimit() {
 
     @Test
     public void testEncodeHexPartialInput() {
-        final byte data[] = "hello world".getBytes(StandardCharsets.UTF_8);
+        final byte[] data = "hello world".getBytes(StandardCharsets.UTF_8);
 
         char[] hex = Hex.encodeHex(data, 0, 0, true);
         assertArrayEquals(new char[0], hex);
@@ -556,14 +556,14 @@ public void testEncodeHexPartialInput() {
 
     @Test
     public void testEncodeHexPartialInputUnderbounds() {
-        final byte data[] = "hello world".getBytes(StandardCharsets.UTF_8);
+        final byte[] data = "hello world".getBytes(StandardCharsets.UTF_8);
 
         assertThrows(ArrayIndexOutOfBoundsException.class, () -> Hex.encodeHex(data, -2, 10, true));
     }
 
     @Test
     public void testEncodeHexPartialInputOverbounds() {
-        final byte data[] = "hello world".getBytes(StandardCharsets.UTF_8);
+        final byte[] data = "hello world".getBytes(StandardCharsets.UTF_8);
 
         assertThrows(ArrayIndexOutOfBoundsException.class, () -> Hex.encodeHex(data, 9, 10, true));
     }

src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java

@@ -60,7 +60,7 @@ public void testCorrectness() throws Exception {
     final Random random1 = new Random();
     final Random random2 = new Random();
     for (int i = 0; i < 10000; i++) {
-      final byte randomBytes[] = new byte[random1.nextInt(2048)];
+      final byte[] randomBytes = new byte[random1.nextInt(2048)];
       random2.nextBytes(randomBytes);
       checkOnBytes(randomBytes, false);
     }

src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java

@@ -50,7 +50,7 @@ private static boolean hasTestCase(final String re) {
     }
 
     // Character sequences to be tested by the code
-    private static final String MATCHES[] = {
+    private static final String[] MATCHES = {
             ".*[AEIOUJY].*",         // A, E, I, J, O, U, Y
             ".*H.*",                 // H
             ".*B.*",                 // B
@@ -229,19 +229,19 @@ public void testIsEncodeEquals() {
 
     @Test
     public void testVariationsMella() throws EncoderException {
-        final String data[] = {"mella", "milah", "moulla", "mellah", "muehle", "mule"};
+        final String[] data = {"mella", "milah", "moulla", "mellah", "muehle", "mule"};
         this.checkEncodingVariations("65", data);
     }
 
     @Test
     public void testVariationsMeyer() throws EncoderException {
-        final String data[] = {"Meier", "Maier", "Mair", "Meyer", "Meyr", "Mejer", "Major"};
+        final String[] data = {"Meier", "Maier", "Mair", "Meyer", "Meyr", "Mejer", "Major"};
         this.checkEncodingVariations("67", data);
     }
 
     @Test
     public void testSpecialCharsBetweenSameLetters() throws EncoderException {
-        final String data[] = {"Test test", "Testtest", "Test-test", "TesT#Test", "TesT?test"};
+        final String[] data = {"Test test", "Testtest", "Test-test", "TesT#Test", "TesT?test"};
         this.checkEncodingVariations("28282", data);
     }
 

src/test/java/org/apache/commons/codec/net/BCodecTest.java

@@ -45,10 +45,10 @@ public class BCodecTest {
             "=?ASCII?B?AB==?="
     };
 
-    static final int SWISS_GERMAN_STUFF_UNICODE[] =
+    static final int[] SWISS_GERMAN_STUFF_UNICODE =
         { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 };
 
-    static final int RUSSIAN_STUFF_UNICODE[] =
+    static final int[] RUSSIAN_STUFF_UNICODE =
         { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 };
 
     private String constructString(final int[] unicodeChars) {