Simplify - don't cache dynamic length

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1842178 13f79535-47bb-0310-9956-ffa450edef68

Author: sebbASF

src/main/java/org/apache/commons/codec/language/ColognePhonetic.java

@@ -325,12 +325,10 @@ public String colognePhonetic(String text) {
         char code;
         char chr;
 
-        int rightLength = input.length();
-
-        while (rightLength > 0) {
+        while (input.length() > 0) {
             chr = input.removeNext();
 
-            if ((rightLength = input.length()) > 0) {
+            if (input.length() > 0) {
                 nextChar = input.getNextChar();
             } else {
                 nextChar = '-';
@@ -354,7 +352,6 @@ public String colognePhonetic(String text) {
             } else if (chr == 'X' && !arrayContains(CKQ, lastChar)) {
                 code = '4';
                 input.addLeft('S');
-                rightLength++;
             } else if (chr == 'S' || chr == 'Z') {
                 code = '8';
             } else if (chr == 'C') {