Make new charsetName instance variable thread-safe

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@801639 13f79535-47bb-0310-9956-ffa450edef68

Author: Niall Kegan Pemberton

src/java/org/apache/commons/codec/binary/Hex.java

@@ -167,23 +167,25 @@ protected static int toDigit(char ch, int index) throws DecoderException {
         return digit;
     }
 
-    private String charsetName = DEFAULT_CHARSET_NAME;
+    private final String charsetName;
 
     /**
      * Creates a new codec with the default charset name {@link #DEFAULT_CHARSET_NAME}
      */
     public Hex() {
         // use default encoding
+        this.charsetName = DEFAULT_CHARSET_NAME;
     }
 
     /**
      * Creates a new codec with the given charset name.
      * 
      * @param csName
      *            the charset name.
+     * @since 1.4
      */
     public Hex(String csName) {
-        setCharsetName(csName);
+        this.charsetName = csName;
     }
 
     /**
@@ -280,21 +282,12 @@ public Object encode(Object object) throws EncoderException {
      * Gets the charset name.
      * 
      * @return the charset name.
+     * @since 1.4
      */
     public String getCharsetName() {
         return this.charsetName;
     }
 
-    /**
-     * Sets the charset name.
-     * 
-     * @param charsetName
-     *            the charset name.
-     */
-    private void setCharsetName(String charsetName) {
-        this.charsetName = charsetName;
-    }
-
     /**
      * Returns a string representation of the object, which includes the charset name.
      *