Skip to content

Commit 516f688

Browse files
committed
CODEC-215 Constructors must not call overrideable methods
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1744596 13f79535-47bb-0310-9956-ffa450edef68
1 parent d2bfb07 commit 516f688

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public class PureJavaCrc32 implements Checksum {
4343

4444
/** Create a new PureJavaCrc32 object. */
4545
public PureJavaCrc32() {
46-
reset();
46+
_reset();
4747
}
4848

4949
@Override
@@ -53,6 +53,11 @@ public long getValue() {
5353

5454
@Override
5555
public void reset() {
56+
_reset();
57+
}
58+
59+
// called by ctor, so must not be overrideable
60+
private void _reset() {
5661
crc = 0xffffffff;
5762
}
5863

0 commit comments

Comments
 (0)