Why we create the array anew each time

sebbASF · sebbASF · commit 5590b9510bfe · 2016-05-18T11:28:17.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1744392 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/codec/digest/MessageDigestAlgorithms.java b/src/main/java/org/apache/commons/codec/digest/MessageDigestAlgorithms.java
@@ -128,6 +128,7 @@ public class MessageDigestAlgorithms {
      * @since 1.11
      */
     public static String[] values() {
+        // N.B. do not use a constant array here as that can be changed externally by accident or design
         return new String[] { MD2, MD5, SHA_1, SHA_224, SHA_256, SHA_384, SHA_512, SHA3_224, SHA3_256, SHA3_384, SHA3_512 };
     }
 

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,7 @@ public class MessageDigestAlgorithms {`
`128`	`128`	`* @since 1.11`
`129`	`129`	`*/`
`130`	`130`	`public static String[] values() {`
	`131`	`+ // N.B. do not use a constant array here as that can be changed externally by accident or design`
`131`	`132`	`return new String[] { MD2, MD5, SHA_1, SHA_224, SHA_256, SHA_384, SHA_512, SHA3_224, SHA3_256, SHA3_384, SHA3_512 };`
`132`	`133`	`}`
`133`	`134`