FindBugs - don't assign modulus twice

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1064428 13f79535-47bb-0310-9956-ffa450edef68

Author: sebbASF

src/java/org/apache/commons/codec/binary/Base32.java

@@ -344,7 +344,7 @@ void encode(byte[] in, int inPos, int inAvail) { // package protected for access
         } else {
             for (int i = 0; i < inAvail; i++) {
                 ensureBufferSize(encodeSize);
-                modulus = (++modulus) % BYTES_PER_UNENCODED_BLOCK;
+                modulus = (modulus+1) % BYTES_PER_UNENCODED_BLOCK;
                 int b = in[inPos++];
                 if (b < 0) {
                     b += 256;
@@ -409,7 +409,7 @@ void decode(byte[] in, int inPos, int inAvail) { // package protected for access
                 if (b >= 0 && b < this.decodeTable.length) {
                     int result = this.decodeTable[b];
                     if (result >= 0) {
-                        modulus = (++modulus) % BYTES_PER_ENCODED_BLOCK;
+                        modulus = (modulus+1) % BYTES_PER_ENCODED_BLOCK;
                         bitWorkArea = (bitWorkArea << BITS_PER_ENCODED_BYTE) + result; // collect decoded bytes
                         if (modulus == 0) { // we can output the 5 bytes
                             buffer[pos++] = (byte) ((bitWorkArea >> 32) & MASK_8BITS);

src/java/org/apache/commons/codec/binary/Base64.java

@@ -363,7 +363,7 @@ void encode(byte[] in, int inPos, int inAvail) {
         } else {
             for (int i = 0; i < inAvail; i++) {
                 ensureBufferSize(encodeSize);
-                modulus = (++modulus) % BYTES_PER_UNENCODED_BLOCK;
+                modulus = (modulus+1) % BYTES_PER_UNENCODED_BLOCK;
                 int b = in[inPos++];
                 if (b < 0) {
                     b += 256;
@@ -426,7 +426,7 @@ void decode(byte[] in, int inPos, int inAvail) {
                 if (b >= 0 && b < DECODE_TABLE.length) {
                     int result = DECODE_TABLE[b];
                     if (result >= 0) {
-                        modulus = (++modulus) % BYTES_PER_ENCODED_BLOCK;
+                        modulus = (modulus+1) % BYTES_PER_ENCODED_BLOCK;
                         bitWorkArea = (bitWorkArea << BITS_PER_ENCODED_BYTE) + result;
                         if (modulus == 0) {
                             buffer[pos++] = (byte) ((bitWorkArea >> 16) & MASK_8BITS);