Skip to content

Commit 67e7655

Browse files
committed
[CODEC-246] ColognePhoneticTest.testIsEncodeEquals missing assertions.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1832451 13f79535-47bb-0310-9956-ffa450edef68
1 parent 3eef2f7 commit 67e7655

1 file changed

Lines changed: 18 additions & 2 deletions

File tree

src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.apache.commons.codec.EncoderException;
2121
import org.apache.commons.codec.StringEncoderAbstractTest;
2222
import org.junit.Assert;
23+
import org.junit.Ignore;
2324
import org.junit.Test;
2425

2526
/**
@@ -133,20 +134,35 @@ public void testHyphen() throws EncoderException {
133134

134135
@Test
135136
public void testIsEncodeEquals() {
137+
//@formatter:off
136138
final String[][] data = {
137-
{"Meyer", "M\u00fcller"}, // Müller
138139
{"Meyer", "Mayr"},
139140
{"house", "house"},
140141
{"House", "house"},
141142
{"Haus", "house"},
142143
{"ganz", "Gans"},
143144
{"ganz", "G\u00e4nse"}, // Gänse
144145
{"Miyagi", "Miyako"}};
146+
//@formatter:on
147+
for (final String[] element : data) {
148+
final boolean encodeEqual = this.getStringEncoder().isEncodeEqual(element[1], element[0]);
149+
Assert.assertTrue(element[1] + " != " + element[0], encodeEqual);
150+
}
151+
}
152+
153+
@Test
154+
@Ignore("https://issues.apache.org/jira/browse/CODEC-246")
155+
public void testIsEncodeEqualsCodec246() {
156+
//@formatter:off
157+
final String[][] data = {
158+
{"Meyer", "M\u00fcller"}, // Müller
159+
};
160+
//@formatter:on
145161
for (final String[] element : data) {
146162
// This just compares and only shows we do not blow up
147163
final boolean encodeEqual = this.getStringEncoder().isEncodeEqual(element[1], element[0]);
148164
// Fails for https://issues.apache.org/jira/browse/CODEC-246
149-
// Assert.assertTrue(element[1] + " != " + element[0], encodeEqual);
165+
Assert.assertTrue(element[1] + " != " + element[0], encodeEqual);
150166
}
151167
}
152168

0 commit comments

Comments
 (0)