Remove test code that used deprecated constructors for Numbers (calling valueOf) now

Author: kinow

src/test/java/org/apache/commons/codec/StringEncoderAbstractTest.java

@@ -74,7 +74,7 @@ public void testEncodeWithInvalidObject() throws Exception {
         boolean exceptionThrown = false;
         try {
             final StringEncoder encoder = this.getStringEncoder();
-            encoder.encode(new Float(3.4));
+            encoder.encode(Float.valueOf(3.4f));
         } catch (final Exception e) {
             exceptionThrown = true;
         }

src/test/java/org/apache/commons/codec/StringEncoderComparatorTest.java

@@ -69,7 +69,7 @@ public void testComparatorWithDoubleMetaphoneAndInvalidInput() throws Exception
         final StringEncoderComparator sCompare =
             new StringEncoderComparator( new DoubleMetaphone() );
 
-        final int compare = sCompare.compare(new Double(3.0), Long.valueOf(3));
+        final int compare = sCompare.compare(Double.valueOf(3.0d), Long.valueOf(3));
         assertEquals( "Trying to compare objects that make no sense to the underlying encoder should return a zero compare code",
                                 0, compare);
     }

src/test/java/org/apache/commons/codec/net/BCodecTest.java

@@ -117,7 +117,7 @@ public void testEncodeObjects() throws Exception {
         assertEquals("Encoding a null Object should return null", null, result);
 
         try {
-            final Object dObj = new Double(3.0);
+            final Object dObj = Double.valueOf(3.0d);
             bcodec.encode(dObj);
             fail("Trying to url encode a Double object should cause an exception.");
         } catch (final EncoderException ee) {
@@ -141,7 +141,7 @@ public void testDecodeObjects() throws Exception {
         assertEquals("Decoding a null Object should return null", null, result);
 
         try {
-            final Object dObj = new Double(3.0);
+            final Object dObj = Double.valueOf(3.0d);
             bcodec.decode(dObj);
             fail("Trying to url encode a Double object should cause an exception.");
         } catch (final DecoderException ee) {

src/test/java/org/apache/commons/codec/net/QCodecTest.java

@@ -143,7 +143,7 @@ public void testEncodeObjects() throws Exception {
         assertEquals( "Encoding a null Object should return null", null, result);
 
         try {
-            final Object dObj = new Double(3.0);
+            final Object dObj = Double.valueOf(3.0d);
             qcodec.encode( dObj );
             fail( "Trying to url encode a Double object should cause an exception.");
         } catch (final EncoderException ee) {
@@ -169,7 +169,7 @@ public void testDecodeObjects() throws Exception {
         assertEquals( "Decoding a null Object should return null", null, result);
 
         try {
-            final Object dObj = new Double(3.0);
+            final Object dObj = Double.valueOf(3.0d);
             qcodec.decode( dObj );
             fail( "Trying to url encode a Double object should cause an exception.");
         } catch (final DecoderException ee) {

src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java

@@ -201,7 +201,7 @@ public void testEncodeObjects() throws Exception {
         assertEquals( "Encoding a null Object should return null", null, result);
 
         try {
-            final Object dObj = new Double(3.0);
+            final Object dObj = Double.valueOf(3.0d);
             qpcodec.encode( dObj );
             fail( "Trying to url encode a Double object should cause an exception.");
         } catch (final EncoderException ee) {
@@ -232,7 +232,7 @@ public void testDecodeObjects() throws Exception {
         assertEquals( "Decoding a null Object should return null", null, result);
 
         try {
-            final Object dObj = new Double(3.0);
+            final Object dObj = Double.valueOf(3.0d);
             qpcodec.decode( dObj );
             fail( "Trying to url encode a Double object should cause an exception.");
         } catch (final DecoderException ee) {

src/test/java/org/apache/commons/codec/net/URLCodecTest.java

@@ -237,7 +237,7 @@ public void testEncodeObjects() throws Exception {
         assertEquals( "Encoding a null Object should return null", null, result);
 
         try {
-            final Object dObj = new Double(3.0);
+            final Object dObj = Double.valueOf(3.0d);
             urlCodec.encode( dObj );
             fail( "Trying to url encode a Double object should cause an exception.");
         } catch (final EncoderException ee) {
@@ -283,7 +283,7 @@ public void testDecodeObjects() throws Exception {
         assertEquals( "Decoding a null Object should return null", null, result);
 
         try {
-            final Object dObj = new Double(3.0);
+            final Object dObj = Double.valueOf(3.0d);
             urlCodec.decode( dObj );
             fail( "Trying to url encode a Double object should cause an exception.");
         } catch (final DecoderException ee) {