Skip to content

Commit 7ca5b56

Browse files
committed
Use Arrays.fill().
1 parent 0a4b0c6 commit 7ca5b56

2 files changed

Lines changed: 6 additions & 9 deletions

File tree

src/main/java/org/apache/commons/codec/digest/UnixCrypt.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import java.nio.charset.StandardCharsets;
2020
import java.security.SecureRandom;
21+
import java.util.Arrays;
2122
import java.util.concurrent.ThreadLocalRandom;
2223

2324
/**
@@ -217,9 +218,7 @@ public static String crypt(final byte[] original, String salt) {
217218
final int eSwap0 = CON_SALT[charZero];
218219
final int eSwap1 = CON_SALT[charOne] << 4;
219220
final byte key[] = new byte[8];
220-
for (int i = 0; i < key.length; i++) {
221-
key[i] = 0;
222-
}
221+
Arrays.fill(key, (byte) 0);
223222

224223
for (int i = 0; i < key.length && i < original.length; i++) {
225224
final int iChar = original[i];

src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
*/
1717
package org.apache.commons.codec.digest;
1818

19+
import java.util.Arrays;
20+
1921
import org.junit.Assert;
2022
import org.junit.Test;
2123

@@ -32,17 +34,13 @@ public class PureJavaCrc32CTest {
3234

3335
@Test
3436
public void testZeros() {
35-
for(int i = 0; i < data.length; i ++) {
36-
data[i]= (byte) 0;
37-
}
37+
Arrays.fill(data, (byte) 0);
3838
check(0x8a9136aa); // aa 36 91 8a
3939
}
4040

4141
@Test
4242
public void testOnes() {
43-
for(int i = 0; i < data.length; i ++) {
44-
data[i]= (byte) 0xFF;
45-
}
43+
Arrays.fill(data, (byte) 0xFF);
4644
check(0x62a8ab43); // 43 ab a8 62
4745
}
4846

0 commit comments

Comments
 (0)