Add missing tests

Author: adamretter

src/test/java/org/apache/commons/codec/binary/HexTest.java

@@ -17,6 +17,7 @@
 
 package org.apache.commons.codec.binary;
 
+import static java.nio.charset.StandardCharsets.UTF_8;
 import static org.junit.Assert.assertArrayEquals;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
@@ -69,7 +70,7 @@ protected ByteBuffer allocate(final int capacity) {
      * @return the byte buffer
      */
     private ByteBuffer getByteBufferUtf8(final String string) {
-        final byte[] bytes = string.getBytes(StandardCharsets.UTF_8);
+        final byte[] bytes = string.getBytes(UTF_8);
         final ByteBuffer bb = allocate(bytes.length);
         bb.put(bytes);
         bb.flip();
@@ -583,6 +584,48 @@ public void testEncodeHex_ByteBufferWithLimit() {
         }
     }
 
+    @Test
+    public void testEncodeHexPartialInput() {
+        final byte data[] = "hello world".getBytes(UTF_8);
+
+        char[] hex = Hex.encodeHex(data, 0, 0, true);
+        assertArrayEquals(new char[0], hex);
+
+        hex = Hex.encodeHex(data, 0, 1, true);
+        assertArrayEquals("68".toCharArray(), hex);
+
+        hex = Hex.encodeHex(data, 0, 1, false);
+        assertArrayEquals("68".toCharArray(), hex);
+
+        hex = Hex.encodeHex(data, 2, 4, true);
+        assertArrayEquals("6c6c6f20".toCharArray(), hex);
+
+        hex = Hex.encodeHex(data, 2, 4, false);
+        assertArrayEquals("6C6C6F20".toCharArray(), hex);
+
+        hex = Hex.encodeHex(data, 10, 1, true);
+        assertArrayEquals("64".toCharArray(), hex);
+
+        hex = Hex.encodeHex(data, 10, 1, false);
+        assertArrayEquals("64".toCharArray(), hex);
+    }
+
+    @Test(expected=ArrayIndexOutOfBoundsException.class)
+    public void testEncodeHexPartialInputUnderbounds() {
+        final byte data[] = "hello world".getBytes(UTF_8);
+
+        final char[] hex = Hex.encodeHex(data, -2, 10, true);
+        assertArrayEquals("64".toCharArray(), hex);
+    }
+
+    @Test(expected=ArrayIndexOutOfBoundsException.class)
+    public void testEncodeHexPartialInputOverbounds() {
+        final byte data[] = "hello world".getBytes(UTF_8);
+
+        final char[] hex = Hex.encodeHex(data, 9, 10, true);
+        assertArrayEquals("64".toCharArray(), hex);
+    }
+
     @Test
     public void testEncodeHexByteString_ByteBufferOfZeroes() {
         final String c = Hex.encodeHexString(allocate(36));
@@ -670,12 +713,12 @@ public void testEncodeStringEmpty() throws EncoderException {
 
     @Test
     public void testGetCharset() {
-        Assert.assertEquals(StandardCharsets.UTF_8, new Hex(StandardCharsets.UTF_8).getCharset());
+        Assert.assertEquals(UTF_8, new Hex(UTF_8).getCharset());
     }
 
     @Test
     public void testGetCharsetName() {
-        Assert.assertEquals(StandardCharsets.UTF_8.name(), new Hex(StandardCharsets.UTF_8).getCharsetName());
+        Assert.assertEquals(UTF_8.name(), new Hex(UTF_8).getCharsetName());
     }
 
     @Test