Skip to content

Commit 8993f9a

Browse files
Avoid use toString() or substring()in favor of a simplified expression. (#126)
1 parent 610e1ce commit 8993f9a

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -972,7 +972,7 @@ public void appendPrimary(final String value) {
972972
if (value.length() <= addChars) {
973973
this.primary.append(value);
974974
} else {
975-
this.primary.append(value.substring(0, addChars));
975+
this.primary.append(value, 0, addChars);
976976
}
977977
}
978978

@@ -981,7 +981,7 @@ public void appendAlternate(final String value) {
981981
if (value.length() <= addChars) {
982982
this.alternate.append(value);
983983
} else {
984-
this.alternate.append(value.substring(0, addChars));
984+
this.alternate.append(value, 0, addChars);
985985
}
986986
}
987987

src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ public String encode(String input, final Languages.LanguageSet languageSet) {
403403
input = input.toLowerCase(Locale.ENGLISH).replace('-', ' ').trim();
404404

405405
if (this.nameType == NameType.GENERIC) {
406-
if (input.length() >= 2 && input.substring(0, 2).equals("d'")) { // check for d'
406+
if (input.length() >= 2 && input.startsWith("d'")) { // check for d'
407407
final String remainder = input.substring(2);
408408
final String combined = "d" + remainder;
409409
return "(" + encode(remainder) + ")-(" + encode(combined) + ")";

0 commit comments

Comments
 (0)