Use final.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1694610 13f79535-47bb-0310-9956-ffa450edef68

Author: garydgregory

src/main/java/org/apache/commons/codec/binary/CharSequenceUtils.java

@@ -56,8 +56,8 @@ static boolean regionMatches(final CharSequence cs, final boolean ignoreCase, fi
         int tmpLen = length;
 
         while (tmpLen-- > 0) {
-            char c1 = cs.charAt(index1++);
-            char c2 = substring.charAt(index2++);
+            final char c1 = cs.charAt(index1++);
+            final char c2 = substring.charAt(index2++);
 
             if (c1 == c2) {
                 continue;

src/main/java/org/apache/commons/codec/language/bm/Languages.java

@@ -120,7 +120,7 @@ public LanguageSet restrictTo(final LanguageSet other) {
             } else {
                 final SomeLanguages sl = (SomeLanguages) other;
                 final Set<String> ls = new HashSet<String>(Math.min(languages.size(), sl.languages.size()));
-                for (String lang : languages) {
+                for (final String lang : languages) {
                     if (sl.languages.contains(lang)) {
                         ls.add(lang);
                     }
@@ -138,7 +138,7 @@ public LanguageSet merge(final LanguageSet other) {
             } else {
                 final SomeLanguages sl = (SomeLanguages) other;
                 final Set<String> ls = new HashSet<String>(languages);
-                for (String lang : sl.languages) {
+                for (final String lang : sl.languages) {
                   ls.add(lang);
                 }
                 return from(ls);

src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java

@@ -171,7 +171,7 @@ private static final class RulesApplication {
         private final Map<String, List<Rule>> finalRules;
         private final CharSequence input;
 
-        private PhonemeBuilder phonemeBuilder;
+        private final PhonemeBuilder phonemeBuilder;
         private int i;
         private final int maxPhonemes;
         private boolean found;

src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java

@@ -250,7 +250,7 @@ private static boolean isWhitespace(final int b) {
      *            array of bytes to be encoded
      * @return array of bytes containing quoted-printable data
      */
-    public static final byte[] encodeQuotedPrintable(BitSet printable, final byte[] bytes) {
+    public static final byte[] encodeQuotedPrintable(final BitSet printable, final byte[] bytes) {
         return encodeQuotedPrintable(printable, bytes, false);
     }
 
@@ -270,7 +270,7 @@ public static final byte[] encodeQuotedPrintable(BitSet printable, final byte[]
      * @return array of bytes containing quoted-printable data
      * @since 1.10
      */
-    public static final byte[] encodeQuotedPrintable(BitSet printable, final byte[] bytes, boolean strict) {
+    public static final byte[] encodeQuotedPrintable(BitSet printable, final byte[] bytes, final boolean strict) {
         if (bytes == null) {
             return null;
         }
@@ -284,7 +284,7 @@ public static final byte[] encodeQuotedPrintable(BitSet printable, final byte[]
             // encode up to buffer.length - 3, the last three octets will be treated
             // separately for simplification of note #3
             for (int i = 0; i < bytes.length - 3; i++) {
-                int b = getUnsignedOctet(i, bytes);
+                final int b = getUnsignedOctet(i, bytes);
                 if (pos < SAFE_LENGTH) {
                     // up to this length it is safe to add any byte, encoded or not
                     pos += encodeByte(b, !printable.get(b), buffer);

src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java

@@ -186,7 +186,7 @@ void decode(final byte[] pArray, final int i, final int length, final Context co
         };
 
         // When
-        byte actualPaddingByte = codec.pad;
+        final byte actualPaddingByte = codec.pad;
 
         // Then
         assertEquals(0x25, actualPaddingByte);

src/test/java/org/apache/commons/codec/binary/HexTest.java

@@ -232,7 +232,7 @@ public void testDecodeByteBufferObjectEmpty() throws DecoderException {
 
     @Test
     public void testDecodeByteBufferOddCharacters() {
-        ByteBuffer buffer = ByteBuffer.allocate(1);
+        final ByteBuffer buffer = ByteBuffer.allocate(1);
         buffer.put((byte) 65);
         try {
             new Hex().decode(buffer);

src/test/java/org/apache/commons/codec/language/DaitchMokotoffSoundexTest.java

@@ -36,11 +36,11 @@ protected DaitchMokotoffSoundex createStringEncoder() {
         return new DaitchMokotoffSoundex();
     }
 
-    private String soundex(String source) {
+    private String soundex(final String source) {
         return getStringEncoder().soundex(source);
     }
 
-    private String encode(String source) {
+    private String encode(final String source) {
         return getStringEncoder().encode(source);
     }
 

src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineRegressionTest.java

@@ -182,7 +182,7 @@ public void testCompatibilityWithOriginalVersion() {
         // see CODEC-187
         // comparison: http://stevemorse.org/census/soundex.html
 
-        Map<String, String> args = new TreeMap<String, String>();
+        final Map<String, String> args = new TreeMap<String, String>();
         args.put("nameType", "GENERIC");
         args.put("ruleType", "APPROX");
 

src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java

@@ -258,10 +258,10 @@ public void testSoftLineBreakDecode() throws Exception {
         final String qpdata = "If you believe that truth=3Dbeauty, then surely=20=\r\nmathematics is the most beautiful branch of philosophy.";
         final String expected = "If you believe that truth=beauty, then surely mathematics is the most beautiful branch of philosophy.";
 
-        QuotedPrintableCodec qpcodec = new QuotedPrintableCodec();
+        final QuotedPrintableCodec qpcodec = new QuotedPrintableCodec();
         assertEquals(expected, qpcodec.decode(qpdata));
 
-        String encoded = qpcodec.encode(expected);
+        final String encoded = qpcodec.encode(expected);
         assertEquals(expected, qpcodec.decode(encoded));
     }
 
@@ -270,22 +270,22 @@ public void testSoftLineBreakEncode() throws Exception {
         final String qpdata = "If you believe that truth=3Dbeauty, then surely mathematics is the most b=\r\neautiful branch of philosophy.";
         final String expected = "If you believe that truth=beauty, then surely mathematics is the most beautiful branch of philosophy.";
 
-        QuotedPrintableCodec qpcodec = new QuotedPrintableCodec(true);
+        final QuotedPrintableCodec qpcodec = new QuotedPrintableCodec(true);
         assertEquals(qpdata, qpcodec.encode(expected));
 
-        String decoded = qpcodec.decode(qpdata);
+        final String decoded = qpcodec.decode(qpdata);
         assertEquals(qpdata, qpcodec.encode(decoded));
     }
 
     @Test
     public void testSkipNotEncodedCRLF() throws Exception {
-        String qpdata = "CRLF in an\n encoded text should be=20=\r\n\rskipped in the\r decoding.";
-        String expected = "CRLF in an encoded text should be skipped in the decoding.";
+        final String qpdata = "CRLF in an\n encoded text should be=20=\r\n\rskipped in the\r decoding.";
+        final String expected = "CRLF in an encoded text should be skipped in the decoding.";
 
-        QuotedPrintableCodec qpcodec = new QuotedPrintableCodec(true);
+        final QuotedPrintableCodec qpcodec = new QuotedPrintableCodec(true);
         assertEquals(expected, qpcodec.decode(qpdata));
 
-        String encoded = qpcodec.encode(expected);
+        final String encoded = qpcodec.encode(expected);
         assertEquals(expected, qpcodec.decode(encoded));
     }