This old tweak doesn't satisfy FindBugs

garydgregory · garydgregory · commit 96610734f6d4 · 2025-07-19T08:28:41.000-04:00
diff --git a/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32C.java b/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32C.java
@@ -635,8 +635,6 @@ public void update(final byte[] b, int off, int len) {
         case 1:
             localCrc = localCrc >>> 8 ^ T[T8_0_START + ((localCrc ^ b[off++]) & 0xff)];
             // falls-through
-        default:
-            break; // satisfy Findbugs
         }
         // Publish crc out to object
         crc = localCrc;

Original file line number	Diff line number	Diff line change
`@@ -635,8 +635,6 @@ public void update(final byte[] b, int off, int len) {`
`635`	`635`	`case 1:`
`636`	`636`	`localCrc = localCrc >>> 8 ^ T[T8_0_START + ((localCrc ^ b[off++]) & 0xff)];`
`637`	`637`	`// falls-through`
`638`		`- default:`
`639`		`- break; // satisfy Findbugs`
`640`	`638`	`}`
`641`	`639`	`// Publish crc out to object`
`642`	`640`	`crc = localCrc;`