CODEC-253: simplify B64

Author: chtompki

src/main/java/org/apache/commons/codec/digest/B64.java

@@ -75,16 +75,11 @@ static void b64from24bit(final byte b2, final byte b1, final byte b0, final int
    * @return a random salt {@link String}.
    */
   static String getRandomSalt(final int num) {
-    final StringBuilder saltString = new StringBuilder(num);
     try {
-      final SecureRandom current = SecureRandom.getInstance("SHA1PRNG");
-      for (int i = 1; i <= num; i++) {
-        saltString.append(B64T.charAt(current.nextInt(B64T.length())));
-      }
+      return getRandomSalt(num, SecureRandom.getInstanceStrong());
     } catch (NoSuchAlgorithmException e) {
-      throw new RuntimeException(e);
+      throw new IllegalStateException(e);
     }
-    return saltString.toString();
   }
 
     /**
@@ -98,10 +93,10 @@ static String getRandomSalt(final int num) {
      * @return a random salt {@link String}.
      */
     static String getRandomSalt(final int num, final Random random) {
-        final StringBuilder saltString = new StringBuilder(num);
-        for (int i = 1; i <= num; i++) {
-            saltString.append(B64T.charAt(random.nextInt(B64T.length())));
-        }
-        return saltString.toString();
+      final StringBuilder saltString = new StringBuilder(num);
+      for (int i = 1; i <= num; i++) {
+        saltString.append(B64T.charAt(random.nextInt(B64T.length())));
+      }
+      return saltString.toString();
     }
 }