Skip to content

Commit ae0da81

Browse files
committed
[CODEC-277] Don't reload standard Charsets in
org.apache.commons.codec.Charsets.
1 parent 6f27ca6 commit ae0da81

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

src/changes/changes.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ The <action> type attribute can be add,update,fix,remove.
5555
<action issue="CODEC-273" dev="ggregory" type="add" due-to="Gary Gregory">Add Path APIs to org.apache.commons.codec.digest.DigestUtils similar to File APIs.</action>
5656
<action issue="CODEC-274" dev="ggregory" type="add" due-to="Gary Gregory">Add SHA-512/224 and SHA-512/256 to DigestUtils for Java 9 and up.</action>
5757
<action issue="CODEC-275" dev="ggregory" type="add" due-to="Claude Warren">Add missing note in javadoc when sign extension error is present #34.</action>
58-
<action issue="CODEC-276" dev="ggregory" type="add" due-to="Gary Gregory">Reliance on default encoding in MurmurHash2 and MurmurHash3.</action>
58+
<action issue="CODEC-276" dev="ggregory" type="fix" due-to="Gary Gregory">Reliance on default encoding in MurmurHash2 and MurmurHash3.</action>
59+
<action issue="CODEC-277" dev="ggregory" type="update" due-to="Gary Gregory">Don't reload standard Charsets in org.apache.commons.codec.Charsets.</action>
5960
</release>
6061

6162
<release version="1.13" date="2019-07-20" description="Feature and fix release.">

src/main/java/org/apache/commons/codec/Charsets.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.apache.commons.codec;
1818

1919
import java.nio.charset.Charset;
20+
import java.nio.charset.StandardCharsets;
2021

2122
/**
2223
* Charsets required of every implementation of the Java platform.
@@ -97,7 +98,7 @@ public static Charset toCharset(final String charset) {
9798
*
9899
* @see <a href="http://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">Standard charsets</a>
99100
*/
100-
public static final Charset ISO_8859_1 = Charset.forName(CharEncoding.ISO_8859_1);
101+
public static final Charset ISO_8859_1 = StandardCharsets.ISO_8859_1;
101102

102103
/**
103104
* Seven-bit ASCII, also known as ISO646-US, also known as the Basic Latin block of the Unicode character set.
@@ -110,7 +111,7 @@ public static Charset toCharset(final String charset) {
110111
*
111112
* @see <a href="http://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">Standard charsets</a>
112113
*/
113-
public static final Charset US_ASCII = Charset.forName(CharEncoding.US_ASCII);
114+
public static final Charset US_ASCII = StandardCharsets.US_ASCII;
114115

115116
/**
116117
* Sixteen-bit Unicode Transformation Format, The byte order specified by a mandatory initial byte-order mark
@@ -124,7 +125,7 @@ public static Charset toCharset(final String charset) {
124125
*
125126
* @see <a href="http://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">Standard charsets</a>
126127
*/
127-
public static final Charset UTF_16 = Charset.forName(CharEncoding.UTF_16);
128+
public static final Charset UTF_16 = StandardCharsets.UTF_16;
128129

129130
/**
130131
* Sixteen-bit Unicode Transformation Format, big-endian byte order.
@@ -137,7 +138,7 @@ public static Charset toCharset(final String charset) {
137138
*
138139
* @see <a href="http://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">Standard charsets</a>
139140
*/
140-
public static final Charset UTF_16BE = Charset.forName(CharEncoding.UTF_16BE);
141+
public static final Charset UTF_16BE = StandardCharsets.UTF_16BE;
141142

142143
/**
143144
* Sixteen-bit Unicode Transformation Format, little-endian byte order.
@@ -150,7 +151,7 @@ public static Charset toCharset(final String charset) {
150151
*
151152
* @see <a href="http://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">Standard charsets</a>
152153
*/
153-
public static final Charset UTF_16LE = Charset.forName(CharEncoding.UTF_16LE);
154+
public static final Charset UTF_16LE = StandardCharsets.UTF_16LE;
154155

155156
/**
156157
* Eight-bit Unicode Transformation Format.
@@ -163,5 +164,5 @@ public static Charset toCharset(final String charset) {
163164
*
164165
* @see <a href="http://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">Standard charsets</a>
165166
*/
166-
public static final Charset UTF_8 = Charset.forName(CharEncoding.UTF_8);
167+
public static final Charset UTF_8 = StandardCharsets.UTF_8;
167168
}

0 commit comments

Comments
 (0)