Skip to content

Commit ae83747

Browse files
committed
CODEC-144 BaseNCodec: encodeToString and encodeAsString methods are identical
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1789156 13f79535-47bb-0310-9956-ffa450edef68
1 parent ad98aec commit ae83747

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

src/changes/changes.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ The <action> type attribute can be add,update,fix,remove.
4545
<release version="1.11" date="2017-MM-DD" description="Feature and fix release.">
4646
<!-- The first attribute below should be the issue id; makes it easier to navigate in the IDE outline -->
4747

48+
<action issue="CODEC-144" dev="sebb" type="fix">BaseNCodec: encodeToString and encodeAsString methods are identical</action>
4849
<action issue="CODEC-232" dev="sebb" type="fix">URLCodec is neither immutable nor threadsafe</action>
4950
<action issue="CODEC-231" dev="sebb" type="fix">StringUtils.equals(CharSequence cs1, CharSequence cs2) can fail with String Index OBE</action>
5051
<action issue="CODEC-230" dev="sebb" type="fix">URLCodec.WWW_FORM_URL should be private</action>

src/main/java/org/apache/commons/codec/binary/BaseNCodec.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,8 @@ public String encodeToString(final byte[] pArray) {
356356
*
357357
* @param pArray a byte array containing binary data
358358
* @return String containing only character data in the appropriate alphabet.
359+
* @since 1.5
360+
* This is a duplicate of {@link #encodeToString(byte[])}; it was merged during refactoring.
359361
*/
360362
public String encodeAsString(final byte[] pArray){
361363
return StringUtils.newStringUtf8(encode(pArray));

0 commit comments

Comments
 (0)