JIRA: CODEC-89 new Base64().encode() appends a CRLF, and chunks results into 76 character lines

sebbASF · sebbASF · commit bcfef8906931 · 2010-03-27T00:02:22.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@928107 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/java/org/apache/commons/codec/binary/Base64.java b/src/java/org/apache/commons/codec/binary/Base64.java
@@ -214,15 +214,15 @@ public class Base64 implements BinaryEncoder, BinaryDecoder {
     /**
      * Creates a Base64 codec used for decoding (all modes) and encoding in URL-unsafe mode.
      * <p>
-     * When encoding the line length is 76, the line separator is CRLF, and the encoding table is STANDARD_ENCODE_TABLE.
+     * When encoding the line length is 0 (no chunking), and the encoding table is STANDARD_ENCODE_TABLE.
      * </p>
      * 
      * <p>
      * When decoding all variants are supported.
      * </p>
      */
     public Base64() {
-        this(false);
+        this(0);
     }
 
     /**
diff --git a/src/java/org/apache/commons/codec/binary/Base64InputStream.java b/src/java/org/apache/commons/codec/binary/Base64InputStream.java
@@ -73,7 +73,7 @@ public Base64InputStream(InputStream in) {
     public Base64InputStream(InputStream in, boolean doEncode) {
         super(in);
         this.doEncode = doEncode;
-        this.base64 = new Base64();
+        this.base64 = new Base64(false);
     }
 
     /**
diff --git a/src/java/org/apache/commons/codec/binary/Base64OutputStream.java b/src/java/org/apache/commons/codec/binary/Base64OutputStream.java
@@ -72,7 +72,7 @@ public Base64OutputStream(OutputStream out) {
     public Base64OutputStream(OutputStream out, boolean doEncode) {
         super(out);
         this.doEncode = doEncode;
-        this.base64 = new Base64();
+        this.base64 = new Base64(false);
     }
 
     /**
diff --git a/xdocs/changes.xml b/xdocs/changes.xml
@@ -23,6 +23,9 @@
     </properties>
     <body>
         <release version="TBA" date="TBA" description="TBC">
+            <action dev="sebb" type="fix" issue="CODEC-89">
+             new Base64().encode() appends a CRLF, and chunks results into 76 character lines
+            </action>
             <action dev="sebb" type="add" issue="CODEC-93" due-to="Julius Davies">
              Add test(s) to check that encodeBase64() does not chunk output.
              </action>

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public Base64InputStream(InputStream in) {`
`73`	`73`	`public Base64InputStream(InputStream in, boolean doEncode) {`
`74`	`74`	`super(in);`
`75`	`75`	`this.doEncode = doEncode;`
`76`		`- this.base64 = new Base64();`
	`76`	`+ this.base64 = new Base64(false);`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public Base64OutputStream(OutputStream out) {`
`72`	`72`	`public Base64OutputStream(OutputStream out, boolean doEncode) {`
`73`	`73`	`super(out);`
`74`	`74`	`this.doEncode = doEncode;`
`75`		`- this.base64 = new Base64();`
	`75`	`+ this.base64 = new Base64(false);`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`/**`