Add final modifier to method parameters

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1811343 13f79535-47bb-0310-9956-ffa450edef68

Author: garydgregory

src/main/java/org/apache/commons/codec/binary/BaseNCodec.java

@@ -483,7 +483,7 @@ public byte[] encode(final byte[] pArray, int offset, int length) {
      *         <code>false</code>, otherwise
      */
     public boolean isInAlphabet(final byte[] arrayOctet, final boolean allowWSPad) {
-        for (byte octet : arrayOctet) {
+        for (final byte octet : arrayOctet) {
             if (!isInAlphabet(octet) &&
                     (!allowWSPad || (octet != pad) && !isWhiteSpace(octet))) {
                 return false;

src/main/java/org/apache/commons/codec/cli/Digest.java

@@ -102,7 +102,7 @@ private void run() throws IOException {
     }
 
     private void run(String[] digestAlgorithms) throws IOException {
-        for (String messageDigestAlgorithm : digestAlgorithms) {
+        for (final String messageDigestAlgorithm : digestAlgorithms) {
             if (DigestUtils.isAvailable(messageDigestAlgorithm)) {
                 run(messageDigestAlgorithm + " ", messageDigestAlgorithm);
             }
@@ -114,7 +114,7 @@ private void run(String prefix, final MessageDigest messageDigest) throws IOExce
             println(prefix, DigestUtils.digest(messageDigest, System.in));
             return;
         }
-        for(String source : inputs) {
+        for(final String source : inputs) {
             final File file = new File(source);
             if (file.isFile()) {
                 println(prefix, DigestUtils.digest(messageDigest, file), source);
@@ -132,7 +132,7 @@ private void run(String prefix, final MessageDigest messageDigest) throws IOExce
     }
 
     private void run(String prefix, MessageDigest messageDigest, File[] files) throws IOException {
-        for (File file : files) {
+        for (final File file : files) {
             if (file.isFile()) {
                 println(prefix, DigestUtils.digest(messageDigest, file), file.getName());
             }

src/main/java/org/apache/commons/codec/digest/HmacUtils.java

@@ -69,7 +69,7 @@ public static boolean isAvailable(String name) {
         try {
             Mac.getInstance(name);
             return true;
-        } catch (NoSuchAlgorithmException e) {
+        } catch (final NoSuchAlgorithmException e) {
             return false;
         }
     }
@@ -85,7 +85,7 @@ public static boolean isAvailable(HmacAlgorithms name) {
         try {
             Mac.getInstance(name.getName());
             return true;
-        } catch (NoSuchAlgorithmException e) {
+        } catch (final NoSuchAlgorithmException e) {
             return false;
         }
     }

src/main/java/org/apache/commons/codec/digest/PureJavaCrc32C.java

@@ -47,7 +47,7 @@ public PureJavaCrc32C() {
 
   @Override
   public long getValue() {
-    long ret = crc;
+    final long ret = crc;
     return (~ret) & 0xffffffffL;
   }
 

src/main/java/org/apache/commons/codec/language/Soundex.java

@@ -160,7 +160,7 @@ public Soundex(final char[] mapping) {
     }
 
     private boolean hasMarker(char[] mapping) {
-        for(char ch : mapping) {
+        for(final char ch : mapping) {
             if (ch == SILENT_MARKER) {
                 return true;
             }
@@ -318,11 +318,11 @@ public String soundex(String str) {
         out[count++] = first;
         char lastDigit = map(first); // previous digit
         for(int i = 1; i < str.length() && count < out.length ; i++) {
-            char ch = str.charAt(i);
+            final char ch = str.charAt(i);
             if ((this.specialCaseHW) && (ch == 'H' || ch == 'W')) { // these are ignored completely
                 continue;
             }
-            char digit = map(ch);
+            final char digit = map(ch);
             if (digit == SILENT_MARKER) {
                 continue;
             }

src/test/java/org/apache/commons/codec/binary/Base32Test.java

@@ -52,7 +52,7 @@ public class Base32Test {
 //            BASE32_BINARY_TEST_CASES[2][0] = new Hex().decode("739ce739ce");
 
     static {
-        Hex hex = new Hex();
+        final Hex hex = new Hex();
         try {
             BASE32_BINARY_TEST_CASES = new Object[][] {
                     new Object[] { hex.decode("623a01735836e9a126e12fbf95e013ee6892997c"),
@@ -62,7 +62,7 @@ public class Base32Test {
                     new Object[] { hex.decode("739ce42108"),
                                    "OOOOIIII" }
             };
-        } catch (DecoderException de) {
+        } catch (final DecoderException de) {
             throw new Error(":(", de);
         }
     }

src/test/java/org/apache/commons/codec/binary/Base64Test.java

@@ -130,7 +130,7 @@ private void testBase64InBuffer(int startPasSize, int endPadSize) {
         final byte[] bytesUtf8 = StringUtils.getBytesUtf8(content);
         byte[] buffer = ArrayUtils.addAll(bytesUtf8, new byte[endPadSize]);
         buffer = ArrayUtils.addAll(new byte[startPasSize], buffer);
-        byte[] encodedBytes = new Base64().encode(buffer, startPasSize, bytesUtf8.length);
+        final byte[] encodedBytes = new Base64().encode(buffer, startPasSize, bytesUtf8.length);
         encodedContent = StringUtils.newStringUtf8(encodedBytes);
         assertEquals("encoding hello world", "SGVsbG8gV29ybGQ=", encodedContent);
     }

src/test/java/org/apache/commons/codec/digest/DigestUtilsTest.java

@@ -64,7 +64,7 @@ File getTestFile() {
     public void setUp() throws Exception {
         new Random().nextBytes(testData);
         testFile = File.createTempFile(DigestUtilsTest.class.getName(), ".dat");
-        FileOutputStream fos = new FileOutputStream(testFile);
+        final FileOutputStream fos = new FileOutputStream(testFile);
         fos.write(testData);
         fos.close();
     }

src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java

@@ -49,7 +49,7 @@ public static Object[] data() {
     }
 
     private static boolean contains(String key) {
-        for(String s : MessageDigestAlgorithms.values()) {
+        for(final String s : MessageDigestAlgorithms.values()) {
             if (s.equals(key)) {
                 return true;
             }
@@ -59,10 +59,10 @@ private static boolean contains(String key) {
 
     @BeforeClass
     public static void checkValues() throws Exception {
-        Field [] fields = MessageDigestAlgorithms.class.getDeclaredFields();
+        final Field [] fields = MessageDigestAlgorithms.class.getDeclaredFields();
         boolean ok = true;
         int psf = 0;
-        for(Field f : fields) {
+        for(final Field f : fields) {
             // Only interested in public fields
             final int modifiers = f.getModifiers();
             if (Modifier.isPublic(modifiers) && Modifier.isStatic(modifiers) && Modifier.isFinal(modifiers)) {

src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java

@@ -66,7 +66,7 @@ public void testDecreasing() {
     private void check(int expected) {
         crc.reset();
         crc.update(data, 0, data.length);
-        int actual = (int) crc.getValue();
+        final int actual = (int) crc.getValue();
         Assert.assertEquals(Integer.toHexString(expected), Integer.toHexString(actual));
     }