Skip to content

Commit e5afc85

Browse files
author
Timothy O'Brien
committed
Checkstyle improvements
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/codec/trunk@130156 13f79535-47bb-0310-9956-ffa450edef68
1 parent f0ff6ed commit e5afc85

4 files changed

Lines changed: 158 additions & 75 deletions

File tree

project.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
maven.checkstyle.properties=${basedir}/checkstyle.properties
66
maven.test.failure = false
77
maven.junit.fork=true
8-
maven.linkcheck.enable=true
8+
maven.linkcheck.enable=false
99

1010
maven.xdoc.date=left
1111
maven.xdoc.version=${pom.currentVersion}

project.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@
146146
<report>maven-junit-report-plugin</report>
147147
<report>maven-jxr-plugin</report>
148148
<report>maven-license-plugin</report>
149-
<report>maven-linkcheck-plugin</report>
149+
<!-- <report>maven-linkcheck-plugin</report> -->
150150
<!-- <report>maven-statcvs-plugin</report> -->
151151
<!-- <report>maven-tasklist-plugin</report> -->
152152
</reports>

src/java/org/apache/commons/codec/base64/Base64.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
/*
2-
* $Header: /home/jerenkrantz/tmp/commons/commons-convert/cvs/home/cvs/jakarta-commons//codec/src/java/org/apache/commons/codec/base64/Attic/Base64.java,v 1.2 2003/05/29 23:03:28 tobrien Exp $
3-
* $Revision: 1.2 $
4-
* $Date: 2003/05/29 23:03:28 $
52
* ====================================================================
63
*
74
* The Apache Software License, Version 1.1
@@ -76,13 +73,16 @@
7673
* 1996. Available at: http://www.ietf.org/rfc/rfc2045.txt
7774
* </p>
7875
* @author Jeffrey Rodriguez
79-
* @version $Revision: 1.2 $ $Date: 2003/05/29 23:03:28 $
76+
* @version $Revision: 1.3 $ $Date: 2003/06/18 18:43:56 $
8077
*
8178
* @deprecated This class has been replaced by
8279
* {@link org.apache.commons.codec.binary.Base64}
8380
*/
8481
public final class Base64 {
8582

83+
/**
84+
* The default character encoding
85+
*/
8686
protected static final String DEFAULT_CHAR_ENCODING = "ISO-8859-1";
8787

8888
/**
@@ -125,10 +125,15 @@ public final class Base64 {
125125
*/
126126
static final byte PAD = (byte) '=';
127127

128-
// Create arrays to hold the base64 characters and a
129-
// lookup for base64 chars
128+
/**
129+
* Create arrays to hold the base64 characters and a
130+
* lookup for base64 chars
131+
*/
130132
private static byte[] base64Alphabet = new byte[BASELENGTH];
131133

134+
/**
135+
* An empty array of type byte
136+
*/
132137
private static final byte[] EMPTY_BYTE_ARRAY = new byte[0];
133138

134139
/**
@@ -342,6 +347,7 @@ public static String encode(String data) {
342347
* @param charEncoding the character encoding to use when converting
343348
* a String to a byte[]
344349
* @return Base64-encoded String
350+
* @throws UnsupportedEncodingException
345351
*/
346352
public static String encode(String data, String charEncoding)
347353
throws UnsupportedEncodingException {

0 commit comments

Comments
 (0)