Add Checkstyle ArrayTypeStyle

Author: garydgregory

src/conf/checkstyle.xml

@@ -48,6 +48,7 @@ limitations under the License.
     <property name="file" value="src/conf/checkstyle-suppressions.xml"/>
   </module>
   <module name="TreeWalker">
+    <module name="ArrayTypeStyle" />
     <module name="AvoidStarImport" />
     <module name="ExplicitInitializationCheck" />
     <module name="FinalLocalVariable" />

src/test/java/org/apache/commons/codec/AbstractStringEncoderTest.java

@@ -41,7 +41,7 @@ protected void checkEncodings(final String[][] data) throws EncoderException {
         }
     }
 
-    protected void checkEncodingVariations(final String expected, final String data[]) throws EncoderException {
+    protected void checkEncodingVariations(final String expected, final String[] data) throws EncoderException {
         for (final String element : data) {
             this.checkEncoding(expected, element);
         }

src/test/java/org/apache/commons/codec/binary/Codec105ErrorInputStream.java

@@ -41,7 +41,7 @@ public int read() throws IOException {
     }
 
     @Override
-    public int read(final byte b[], final int pos, final int len) throws IOException {
+    public int read(final byte[] b, final int pos, final int len) throws IOException {
         if (this.countdown-- > 0) {
             b[pos] = '\n';
             return 1;

src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java

@@ -190,7 +190,7 @@ private static void doBench(final List<Class<? extends Checksum>> crcs, final Pr
             }
         }
 
-        public static void main(final String args[]) throws Exception {
+        public static void main(final String[] args) throws Exception {
             printSystemProperties(System.out);
             doBench(CRCS, System.out);
         }

src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java

@@ -91,7 +91,7 @@ private static boolean hasTestCase(final String re) {
     }
 
     // Allow command-line testing
-    public static void main(final String args[]) {
+    public static void main(final String[] args) {
         final ColognePhonetic coder = new ColognePhonetic();
         for (final String arg : args) {
             final String code = coder.encode(arg);

src/test/java/org/apache/commons/codec/net/QCodecTest.java

@@ -35,9 +35,9 @@
  */
 public class QCodecTest {
 
-    static final int SWISS_GERMAN_STUFF_UNICODE[] = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 };
+    static final int[] SWISS_GERMAN_STUFF_UNICODE = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 };
 
-    static final int RUSSIAN_STUFF_UNICODE[] = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 };
+    static final int[] RUSSIAN_STUFF_UNICODE = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 };
 
     private String constructString(final int[] unicodeChars) {
         final StringBuilder buffer = new StringBuilder();

src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java

@@ -34,9 +34,9 @@
  */
 public class QuotedPrintableCodecTest {
 
-    static final int SWISS_GERMAN_STUFF_UNICODE[] = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 };
+    static final int[] SWISS_GERMAN_STUFF_UNICODE = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 };
 
-    static final int RUSSIAN_STUFF_UNICODE[] = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 };
+    static final int[] RUSSIAN_STUFF_UNICODE = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 };
 
     private String constructString(final int[] unicodeChars) {
         final StringBuilder buffer = new StringBuilder();

src/test/java/org/apache/commons/codec/net/URLCodecTest.java

@@ -33,9 +33,9 @@
  */
 public class URLCodecTest {
 
-    static final int SWISS_GERMAN_STUFF_UNICODE[] = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 };
+    static final int[] SWISS_GERMAN_STUFF_UNICODE = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 };
 
-    static final int RUSSIAN_STUFF_UNICODE[] = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 };
+    static final int[] RUSSIAN_STUFF_UNICODE = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 };
 
     private String constructString(final int[] unicodeChars) {
         final StringBuilder buffer = new StringBuilder();