Use String#isEmpty()

garydgregory · garydgregory · commit fd1cca61236f · 2023-11-28T11:10:33.000-05:00
diff --git a/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java b/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java
@@ -81,7 +81,7 @@ protected String decodeText(final String text)
             throw new DecoderException("RFC 1522 violation: charset token not found");
         }
         final String charset = text.substring(from, to);
-        if (charset.equals("")) {
+        if (charset.isEmpty()) {
             throw new DecoderException("RFC 1522 violation: charset not specified");
         }
         from = to + 1;

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ protected String decodeText(final String text)`
`81`	`81`	`throw new DecoderException("RFC 1522 violation: charset token not found");`
`82`	`82`	`}`
`83`	`83`	`final String charset = text.substring(from, to);`
`84`		`- if (charset.equals("")) {`
	`84`	`+ if (charset.isEmpty()) {`
`85`	`85`	`throw new DecoderException("RFC 1522 violation: charset not specified");`
`86`	`86`	`}`
`87`	`87`	`from = to + 1;`