[CSV-291] Make CSVRecord#values() public.

garydgregory · garydgregory · commit 1e5c7c318190 · 2021-11-02T10:10:03.000-04:00
diff --git a/pom.xml b/pom.xml
@@ -23,7 +23,7 @@
     <version>52</version>
   </parent>
   <artifactId>commons-csv</artifactId>
-  <version>1.9.1-SNAPSHOT</version>
+  <version>1.10.0-SNAPSHOT</version>
   <name>Apache Commons CSV</name>
   <url>https://commons.apache.org/proper/commons-csv/</url>
   <inceptionYear>2005</inceptionYear>
@@ -147,11 +147,11 @@
   </distributionManagement>
 
   <properties>
-    <commons.release.version>1.9.0</commons.release.version>
+    <commons.release.version>1.10.0</commons.release.version>
     <commons.release.desc>(Java 8)</commons.release.desc>
     <!-- The RC version used in the staging repository URL. -->
     <commons.rc.version>RC1</commons.rc.version>
-    <commons.bc.version>1.8</commons.bc.version>
+    <commons.bc.version>1.9.0</commons.bc.version>
     <commons.componentid>csv</commons.componentid>
     <commons.module.name>org.apache.commons.csv</commons.module.name>
     <commons.jira.id>CSV</commons.jira.id>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -38,8 +38,11 @@
     <title>Apache Commons CSV Release Notes</title>
   </properties>
   <body>
-    <release version="1.9.1" date="2021-MM-DD" description="Feature and bug fix release (Java 8)">
-      <action                 type="update" dev="ggregory" due-to="Arturo Bernal">Minor changes #172.</action>
+    <release version="1.10.0" date="2021-MM-DD" description="Feature and bug fix release (Java 8)">
+      <!-- FIX -->
+      <action                 type="fix" dev="ggregory" due-to="Arturo Bernal">Minor changes #172.</action>
+      <!-- ADD -->
+      <action issue="CSV-291" type="add" dev="ggregory" due-to="Gary Gregory">Make CSVRecord#values() public.</action>
       <!-- UPDATE -->
       <action                 type="update" dev="ggregory" due-to="Dependabot">Bump checkstyle from 8.44 to 9.1 #180, #190, #194.</action>
       <action                 type="update" dev="ggregory" due-to="Dependabot">Bump junit-jupiter from 5.8.0-M1 to 5.8.1 #179, #186.</action>
diff --git a/src/main/java/org/apache/commons/csv/CSVRecord.java b/src/main/java/org/apache/commons/csv/CSVRecord.java
@@ -329,7 +329,13 @@ public String toString() {
             Arrays.toString(values) + "]";
     }
 
-    String[] values() {
+    /**
+     * Gets the values for this record. This is not a copy.
+     *
+     * @return the values for this record.
+     * @since 1.10.0
+     */
+    public String[] values() {
         return values;
     }
 
diff --git a/src/site/resources/spotbugs/spotbugs-exclude-filter.xml b/src/site/resources/spotbugs/spotbugs-exclude-filter.xml
@@ -48,4 +48,11 @@
     <Bug pattern="EI_EXPOSE_REP"/>
   </Match>
   
+  <!-- [CSV-291] Make CSVRecord#values() public. -->
+  <Match>
+    <Class name="org.apache.commons.csv.CSVRecord" />
+    <Method name="values" />
+    <Bug pattern="EI_EXPOSE_REP"/>
+  </Match>
+  
 </FindBugsFilter>

Original file line number	Diff line number	Diff line change
`@@ -329,7 +329,13 @@ public String toString() {`
`329`	`329`	`Arrays.toString(values) + "]";`
`330`	`330`	`}`
`331`	`331`
`332`		`- String[] values() {`
	`332`	`+ /**`
	`333`	`+ * Gets the values for this record. This is not a copy.`
	`334`	`+ *`
	`335`	`+ * @return the values for this record.`
	`336`	`+ * @since 1.10.0`
	`337`	`+ */`
	`338`	`+ public String[] values() {`
`333`	`339`	`return values;`
`334`	`340`	`}`
`335`	`341`