CSV-244 Test case failures following CSVFormat#equals() update

sebbASF · sebbASF · commit 42b9fdb099a4 · 2019-06-15T14:29:30.000+01:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -39,6 +39,7 @@
   </properties>
   <body>
     <release version="1.8" date="2019-MM-DD" description="Feature and bug fix release (Java 8)">
+      <action issue="CSV-244" type="fix" dev="sebb">Test case failures following CSVFormat#equals() update.</action>
       <action issue="CSV-243" type="fix" dev="sebb">CSVFormat withTrim() and withIgnoreSurroundingSpaces() need better docs.</action>
       <action issue="CSV-242" type="fix" dev="sebb">CSVFormat equals() and hashCode() don't use all fields.</action>
       <action issue="CSV-241" type="fix" dev="ggregory" due-to="LuckyIlam, Gary Gregory">CSVFormat#valiadte() does not account for allowDuplicateHeaderNames #43.</action>
diff --git a/src/test/java/org/apache/commons/csv/CSVFormatTest.java b/src/test/java/org/apache/commons/csv/CSVFormatTest.java
@@ -517,10 +517,11 @@ public void testHashCodeAndWithIgnoreHeaderCase() {
         final CSVFormat csvFormatTwo = csvFormat.withIgnoreHeaderCase();
         csvFormatTwo.hashCode();
 
-        assertTrue(csvFormatTwo.getIgnoreHeaderCase());
+        assertFalse(csvFormat.getIgnoreHeaderCase());
+        assertTrue(csvFormatTwo.getIgnoreHeaderCase()); // now different
         assertFalse(csvFormatTwo.getTrailingDelimiter());
 
-        assertTrue(csvFormatTwo.equals(csvFormat)); // TODO this fails since CSV-242 was applied. Why should they compare equal?
+        assertFalse(csvFormatTwo.equals(csvFormat)); // CSV-244 - should not be equal
         assertFalse(csvFormatTwo.getAllowMissingColumnNames());
 
         assertFalse(csvFormatTwo.getTrim());
@@ -969,7 +970,7 @@ public void testWithHeaderComments() {
         assertNotSame(csvFormat, csvFormatTwo);
         assertNotSame(csvFormatTwo, csvFormat);
 
-        assertTrue(csvFormatTwo.equals(csvFormat)); // TODO this fails since CSV-242 was applied. Why should the formats compare equal?
+        assertFalse(csvFormatTwo.equals(csvFormat)); // CSV-244 - should not be equal
 
         final String string = csvFormatTwo.format(objectArray);
 
@@ -1031,9 +1032,9 @@ public void testWithHeaderComments() {
         assertNotSame(csvFormatTwo, csvFormat);
 
         assertNotNull(string);
-        assertTrue(csvFormat.equals(csvFormatTwo));
+        assertFalse(csvFormat.equals(csvFormatTwo)); // CSV-244 - should not be equal
 
-        assertTrue(csvFormatTwo.equals(csvFormat));
+        assertFalse(csvFormatTwo.equals(csvFormat)); // CSV-244 - should not be equal
         assertEquals(",,,,,,,", string);
 
     }
