Commit ce08e8c
committed
[CSV-328] Fix quoted null string after disabling quote
setNullString(String) rebuilt quotedNullString by concatenating the nullable
quoteCharacter field directly, so calling setQuote(null) before setNullString(...)
produced a literal "nullNULLnull". Extract a shared setQuotedNullString() helper
that applies the default-quote fallback, so both builder orders produce the same state.
Reviewed-by: OpenAI Codex
Reviewed-by: Anthropic Claude Code1 parent ed8dbf2 commit ce08e8c
3 files changed
Lines changed: 12 additions & 2 deletions
File tree
- src
- changes
- main/java/org/apache/commons/csv
- test/java/org/apache/commons/csv
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
780 | 780 | | |
781 | 781 | | |
782 | 782 | | |
783 | | - | |
| 783 | + | |
784 | 784 | | |
785 | 785 | | |
786 | 786 | | |
| |||
806 | 806 | | |
807 | 807 | | |
808 | 808 | | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
809 | 814 | | |
810 | 815 | | |
811 | | - | |
812 | 816 | | |
813 | 817 | | |
814 | 818 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1040 | 1040 | | |
1041 | 1041 | | |
1042 | 1042 | | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
1043 | 1048 | | |
1044 | 1049 | | |
1045 | 1050 | | |
| |||
0 commit comments