BufferedFileChannelInputStream.read() should return -1 after the stream

is closed

Author: garydgregory

src/changes/changes.xml

@@ -69,6 +69,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action dev="ggregory" type="add"                due-to="Gary Gregory">CircularInputStream.available() should return 0 when the stream is closed.</action>
       <action dev="ggregory" type="add"                due-to="Gary Gregory">InfiniteCircularInputStream.available() should return 0 when the stream is closed.</action>
       <action dev="ggregory" type="add"                due-to="Gary Gregory">ChecksumInputStream(InputStream, Checksum, long, long) should fail-fast on null Checksum input.</action>
+      <action dev="ggregory" type="add"                due-to="Gary Gregory">BufferedFileChannelInputStream.read() should return -1 after the stream is closed.</action>
       <!-- UPDATE -->
       <action dev="ggregory" type="update"             due-to="Dependabot">Bump tests commons.bytebuddy.version from 1.14.13 to 1.14.17 #615, #621, #631, #635.</action>
       <action dev="ggregory" type="update"             due-to="Dependabot">Bump tests commons-codec:commons-codec from 1.16.1 to 1.17.0.</action>

src/main/java/org/apache/commons/io/input/BufferedFileChannelInputStream.java

@@ -243,6 +243,9 @@ public synchronized int read(final byte[] b, final int offset, int len) throws I
      * @throws IOException if an I/O error occurs.
      */
     private boolean refill() throws IOException {
+        if (!fileChannel.isOpen()) {
+            return false;
+        }
         if (!byteBuffer.hasRemaining()) {
             byteBuffer.clear();
             int nRead = 0;

src/test/java/org/apache/commons/io/input/BufferedFileChannelInputStreamTest.java

@@ -83,5 +83,13 @@ public void testBuilderGet() {
         assertThrows(IllegalStateException.class, () -> BufferedFileChannelInputStream.builder().get());
     }
 
+    @Test
+    public void testReadAfterClose() throws Exception {
+        for (final InputStream inputStream : inputStreams) {
+            inputStream.close();
+            assertEquals(IOUtils.EOF, inputStream.read());
+        }
+    }
+
 
 }