Explicit case skip

garydgregory · garydgregory · commit 112399c7fec8 · 2024-11-02T08:10:30.000-04:00
diff --git a/src/main/java/org/apache/commons/io/RandomAccessFileMode.java b/src/main/java/org/apache/commons/io/RandomAccessFileMode.java
@@ -108,15 +108,16 @@ public static RandomAccessFileMode valueOf(final OpenOption... openOption) {
                     }
                     break;
                 default:
-                    // skip
+                    // explicit case skip (spotbugs)
+                    continue;
                 }
             }
         }
         return bestFit;
     }
 
     /**
-     * Gets the enum value for the given mode, one of one of {@value #R}, {@value #RW}, {@value #RWD}, or {@value #RWS}.
+     * Gets the {@link RandomAccessFileMode} value for the given mode, one of {@value #R}, {@value #RW}, {@value #RWD}, or {@value #RWS}.
      *
      * @param mode one of {@value #R}, {@value #RW}, {@value #RWD}, or {@value #RWS}.
      * @return A RandomAccessFileMode.

Original file line number	Diff line number	Diff line change
`@@ -108,15 +108,16 @@ public static RandomAccessFileMode valueOf(final OpenOption... openOption) {`
`108`	`108`	`}`
`109`	`109`	`break;`
`110`	`110`	`default:`
`111`		`- // skip`
	`111`	`+ // explicit case skip (spotbugs)`
	`112`	`+ continue;`
`112`	`113`	`}`
`113`	`114`	`}`
`114`	`115`	`}`
`115`	`116`	`return bestFit;`
`116`	`117`	`}`
`117`	`118`
`118`	`119`	`/**`
`119`		`- * Gets the enum value for the given mode, one of one of {@value #R}, {@value #RW}, {@value #RWD}, or {@value #RWS}.`
	`120`	`+ * Gets the {@link RandomAccessFileMode} value for the given mode, one of {@value #R}, {@value #RW}, {@value #RWD}, or {@value #RWS}.`
`120`	`121`	`*`
`121`	`122`	`* @param mode one of {@value #R}, {@value #RW}, {@value #RWD}, or {@value #RWS}.`
`122`	`123`	`* @return A RandomAccessFileMode.`