Refactor internals

Gary Gregory · Gary Gregory · commit 153a91c1271f · 2022-09-17T17:00:31.000-04:00
diff --git a/src/main/java/org/apache/commons/io/IOExceptionList.java b/src/main/java/org/apache/commons/io/IOExceptionList.java
@@ -51,11 +51,15 @@ public static void checkEmpty(final List<? extends Throwable> causeList, final O
     }
 
     private static boolean isEmpty(final List<? extends Throwable> causeList) {
-        return causeList == null || causeList.isEmpty();
+        return size(causeList) == 0;
+    }
+
+    private static int size(final List<? extends Throwable> causeList) {
+        return causeList != null ? causeList.size() : 0;
     }
 
     private static String toMessage(final List<? extends Throwable> causeList) {
-        return String.format("%,d exception(s): %s", causeList == null ? 0 : causeList.size(), causeList);
+        return String.format("%,d exception(s): %s", size(causeList), causeList);
     }
 
     private final List<? extends Throwable> causeList;

Original file line number	Diff line number	Diff line change
`@@ -51,11 +51,15 @@ public static void checkEmpty(final List<? extends Throwable> causeList, final O`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`private static boolean isEmpty(final List<? extends Throwable> causeList) {`
`54`		`- return causeList == null \|\| causeList.isEmpty();`
	`54`	`+ return size(causeList) == 0;`
	`55`	`+ }`
	`56`	`+`
	`57`	`+ private static int size(final List<? extends Throwable> causeList) {`
	`58`	`+ return causeList != null ? causeList.size() : 0;`
`55`	`59`	`}`
`56`	`60`
`57`	`61`	`private static String toMessage(final List<? extends Throwable> causeList) {`
`58`		`- return String.format("%,d exception(s): %s", causeList == null ? 0 : causeList.size(), causeList);`
	`62`	`+ return String.format("%,d exception(s): %s", size(causeList), causeList);`
`59`	`63`	`}`
`60`	`64`
`61`	`65`	`private final List<? extends Throwable> causeList;`