Skip to content

Commit 1c6de0e

Browse files
committed
Cleanly separate some plugin configurations in profiles
1 parent 18d07b6 commit 1c6de0e

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

pom.xml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -564,6 +564,17 @@ file comparators, endian transformation classes, and much more.
564564
</plugins>
565565
</build>
566566
</profile>
567+
<profile>
568+
<id>java9-compile</id>
569+
<activation>
570+
<jdk>[9,)</jdk>
571+
</activation>
572+
<properties>
573+
<!-- coverall version 4.3.0 does not work with java 9, see https://github.com/trautonen/coveralls-maven-plugin/issues/112 -->
574+
<coveralls.skip>true</coveralls.skip>
575+
<maven.compiler.release>8</maven.compiler.release>
576+
</properties>
577+
</profile>
567578
<profile>
568579
<id>java9+</id>
569580
<activation>
@@ -573,11 +584,6 @@ file comparators, endian transformation classes, and much more.
573584
-->
574585
<jdk>[9,11)</jdk>
575586
</activation>
576-
<properties>
577-
<!-- coverall version 4.3.0 does not work with java 9, see https://github.com/trautonen/coveralls-maven-plugin/issues/112 -->
578-
<coveralls.skip>true</coveralls.skip>
579-
<maven.compiler.release>8</maven.compiler.release>
580-
</properties>
581587
<build>
582588
<plugins>
583589
<plugin>

0 commit comments

Comments
 (0)