Fetch char once from array

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/io/trunk@1465504 13f79535-47bb-0310-9956-ffa450edef68

Author: sebbASF

src/main/java/org/apache/commons/io/FilenameUtils.java

@@ -1376,19 +1376,20 @@ static String[] splitOnTokens(final String text) {
         final ArrayList<String> list = new ArrayList<String>();
         final StringBuilder buffer = new StringBuilder();
         for (int i = 0; i < array.length; i++) {
-            if (array[i] == '?' || array[i] == '*') {
+            final char ch = array[i];
+            if (ch == '?' || ch == '*') {
                 if (buffer.length() != 0) {
                     list.add(buffer.toString());
                     buffer.setLength(0);
                 }
-                if (array[i] == '?') {
+                if (ch == '?') {
                     list.add("?");
-                } else if (list.isEmpty() ||
+                } else if (list.isEmpty() || // ch == '*' here; check if previous char was '*'
                         i > 0 && list.get(list.size() - 1).equals("*") == false) {
                     list.add("*");
                 }
             } else {
-                buffer.append(array[i]);
+                buffer.append(ch);
             }
         }
         if (buffer.length() != 0) {