Skip to content

Commit 37ba41f

Browse files
author
Gary Gregory
committed
Use final.
1 parent 75b2d86 commit 37ba41f

5 files changed

Lines changed: 10 additions & 10 deletions

File tree

src/main/java/org/apache/commons/io/FileUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2820,7 +2820,7 @@ public static File[] toFiles(final URL... urls) {
28202820
return files;
28212821
}
28222822

2823-
private static List<File> toList(Stream<File> stream) {
2823+
private static List<File> toList(final Stream<File> stream) {
28242824
return stream.collect(Collectors.toList());
28252825
}
28262826

src/main/java/org/apache/commons/io/file/CountingPathVisitor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public CountingPathVisitor(final PathCounters pathCounter) {
7575
* @param dirFilter Filters which directories to count.
7676
* @since 2.9.0
7777
*/
78-
public CountingPathVisitor(final PathCounters pathCounter, final PathFilter fileFilter, PathFilter dirFilter) {
78+
public CountingPathVisitor(final PathCounters pathCounter, final PathFilter fileFilter, final PathFilter dirFilter) {
7979
super();
8080
this.pathCounters = Objects.requireNonNull(pathCounter, "pathCounter");
8181
this.fileFilter = Objects.requireNonNull(fileFilter, "fileFilter");
@@ -115,7 +115,7 @@ public FileVisitResult postVisitDirectory(final Path dir, final IOException exc)
115115
}
116116

117117
@Override
118-
public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attributes) throws IOException {
118+
public FileVisitResult preVisitDirectory(final Path dir, final BasicFileAttributes attributes) throws IOException {
119119
final FileVisitResult accept = dirFilter.accept(dir, attributes);
120120
return accept != FileVisitResult.CONTINUE ? FileVisitResult.SKIP_SUBTREE : FileVisitResult.CONTINUE;
121121
}

src/main/java/org/apache/commons/io/file/PathUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -899,7 +899,7 @@ public static <T extends FileVisitor<? super Path>> T visitFileTree(final T visi
899899
* @since 2.9.0
900900
*/
901901
public static Stream<Path> walk(final Path start, final PathFilter pathFilter, final int maxDepth,
902-
boolean readAttributes, final FileVisitOption... options) throws IOException {
902+
final boolean readAttributes, final FileVisitOption... options) throws IOException {
903903
return Files.walk(start, maxDepth, options).filter(path -> pathFilter.accept(path,
904904
readAttributes ? readBasicFileAttributesQuietly(path) : null) == FileVisitResult.CONTINUE);
905905
}

src/main/java/org/apache/commons/io/filefilter/PathEqualsFileFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ public PathEqualsFileFilter(final Path file) {
4545
}
4646

4747
@Override
48-
public boolean accept(File file) {
48+
public boolean accept(final File file) {
4949
return Objects.equals(this.path, file.toPath());
5050
}
5151

5252
@Override
53-
public FileVisitResult accept(Path path, BasicFileAttributes attributes) {
53+
public FileVisitResult accept(final Path path, final BasicFileAttributes attributes) {
5454
return toFileVisitResult(Objects.equals(this.path, path), path);
5555
}
5656
}

src/test/java/org/apache/commons/io/FileUtilsTestCase.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ private void backDateFile10Minutes(final File testFile) throws IOException {
169169
assertNotEquals(getLastModifiedMillis(testFile), lastModified1, "Should have changed source date");
170170
}
171171

172-
private void consumeRemaining(Iterator<File> iterator) {
172+
private void consumeRemaining(final Iterator<File> iterator) {
173173
if (iterator != null) {
174174
iterator.forEachRemaining(e -> {});
175175
}
@@ -221,12 +221,12 @@ private String getName() {
221221
}
222222

223223
private void iterateFilesAndDirs(final File dir, final IOFileFilter fileFilter,
224-
final IOFileFilter dirFilter, Collection<File> expectedFilesAndDirs) {
224+
final IOFileFilter dirFilter, final Collection<File> expectedFilesAndDirs) {
225225
Iterator<File> iterator;
226226
int filesCount = 0;
227227
iterator = FileUtils.iterateFilesAndDirs(dir, fileFilter, dirFilter);
228228
try {
229-
List<File> actualFiles = new ArrayList<>();
229+
final List<File> actualFiles = new ArrayList<>();
230230
while (iterator.hasNext()) {
231231
filesCount++;
232232
final File file = iterator.next();
@@ -1919,7 +1919,7 @@ public void testIterateFilesAndDirs() throws IOException {
19191919
iterateFilesAndDirs(subDir1, fileFilterAllFiles, fileFilterAllDirs, expectedFilesAndDirs);
19201920
//
19211921
// "*.txt" and "*"
1922-
int filesCount;
1922+
final int filesCount;
19231923
expectedFilesAndDirs = Arrays.asList(subDir1, subDir2, someFile, subDir3, subDir4);
19241924
iterateFilesAndDirs(subDir1, fileFilterExtTxt, fileFilterAllDirs, expectedFilesAndDirs);
19251925
//

0 commit comments

Comments
 (0)