[IO-829] Don't decode and reencode characters in a potentially different

charset in AbstractOrigin.CharSequenceOrigin.getReader(Charset)

Javadoc

Author: garydgregory

src/main/java/org/apache/commons/io/build/AbstractOrigin.java

@@ -78,6 +78,12 @@ public byte[] getByteArray() {
             return get();
         }
 
+        /**
+         * {@inheritDoc}
+         * <p>
+         * The {@code options} parameter is ignored since a {@code byte[]} does not need an {@link OpenOption} to be read.
+         * </p>
+         */
         @Override
         public InputStream getInputStream(final OpenOption... options) throws IOException {
             return new ByteArrayInputStream(origin);
@@ -118,7 +124,7 @@ public byte[] getByteArray() {
         /**
          * {@inheritDoc}
          * <p>
-         * In this case, the {@code charset} parameter is ignored, since a {@link CharSequence} does not need a {@link Charset} to be read.
+         * The {@code charset} parameter is ignored since a {@link CharSequence} does not need a {@link Charset} to be read.
          * </p>
          */
         @Override
@@ -127,6 +133,12 @@ public CharSequence getCharSequence(final Charset charset) {
             return get();
         }
 
+        /**
+         * {@inheritDoc}
+         * <p>
+         * The {@code options} parameter is ignored since a {@link CharSequence} does not need an {@link OpenOption} to be read.
+         * </p>
+         */
         @Override
         public InputStream getInputStream(final OpenOption... options) throws IOException {
             // TODO Pass in a Charset? Consider if call sites actually need this.
@@ -136,11 +148,11 @@ public InputStream getInputStream(final OpenOption... options) throws IOExceptio
         /**
          * {@inheritDoc}
          * <p>
-         * In this case, the {@code charset} parameter is ignored, since a {@link CharSequence} does not need a {@link Charset} to be read.
+         * The {@code charset} parameter is ignored since a {@link CharSequence} does not need a {@link Charset} to be read.
          * </p>
          */
         @Override
-        public Reader getReader(final Charset ignore) throws IOException {
+        public Reader getReader(final Charset charset) throws IOException {
             return new CharSequenceReader(get());
         }
 
@@ -210,6 +222,12 @@ public byte[] getByteArray() throws IOException {
             return IOUtils.toByteArray(origin);
         }
 
+        /**
+         * {@inheritDoc}
+         * <p>
+         * The {@code options} parameter is ignored since a {@link InputStream} does not need an {@link OpenOption} to be read.
+         * </p>
+         */
         @Override
         public InputStream getInputStream(final OpenOption... options) {
             // No conversion
@@ -240,12 +258,24 @@ public OutputStreamOrigin(final OutputStream origin) {
             super(origin);
         }
 
+        /**
+         * {@inheritDoc}
+         * <p>
+         * The {@code options} parameter is ignored since a {@link OutputStream} does not need an {@link OpenOption} to be written.
+         * </p>
+         */
         @Override
         public OutputStream getOutputStream(final OpenOption... options) {
             // No conversion
             return get();
         }
 
+        /**
+         * {@inheritDoc}
+         * <p>
+         * The {@code options} parameter is ignored since a {@link OutputStream} does not need an {@link OpenOption} to be written.
+         * </p>
+         */
         @Override
         public Writer getWriter(final Charset charset, final OpenOption... options) throws IOException {
             return new OutputStreamWriter(origin, charset);
@@ -312,17 +342,35 @@ public byte[] getByteArray() throws IOException {
             return IOUtils.toByteArray(origin, Charset.defaultCharset());
         }
 
+        /**
+         * {@inheritDoc}
+         * <p>
+         * The {@code charset} parameter is ignored since a {@link Reader} does not need a {@link Charset} to be read.
+         * </p>
+         */
         @Override
         public CharSequence getCharSequence(final Charset charset) throws IOException {
             return IOUtils.toString(origin);
         }
 
+        /**
+         * {@inheritDoc}
+         * <p>
+         * The {@code options} parameter is ignored since a {@link Reader} does not need an {@link OpenOption} to be read.
+         * </p>
+         */
         @Override
         public InputStream getInputStream(final OpenOption... options) throws IOException {
             // TODO Pass in a Charset? Consider if call sites actually need this.
             return ReaderInputStream.builder().setReader(origin).setCharset(Charset.defaultCharset()).get();
         }
 
+        /**
+         * {@inheritDoc}
+         * <p>
+         * The {@code charset} parameter is ignored since a {@link Reader} does not need a {@link Charset} to be read.
+         * </p>
+         */
         @Override
         public Reader getReader(final Charset charset) throws IOException {
             // No conversion
@@ -373,12 +421,27 @@ public WriterOrigin(final Writer origin) {
             super(origin);
         }
 
+        /**
+         * {@inheritDoc}
+         * <p>
+         * The {@code options} parameter is ignored since a {@link Writer} does not need an {@link OpenOption} to be written.
+         * </p>
+         */
         @Override
         public OutputStream getOutputStream(final OpenOption... options) throws IOException {
             // TODO Pass in a Charset? Consider if call sites actually need this.
             return WriterOutputStream.builder().setWriter(origin).setCharset(Charset.defaultCharset()).get();
         }
 
+        /**
+         * {@inheritDoc}
+         * <p>
+         * The {@code charset} parameter is ignored since a {@link Writer} does not need a {@link Charset} to be written.
+         * </p>
+         * <p>
+         * The {@code options} parameter is ignored since a {@link Writer} does not need an {@link OpenOption} to be written.
+         * </p>
+         */
         @Override
         public Writer getWriter(final Charset charset, final OpenOption... options) throws IOException {
             // No conversion