IO-214 Inconsistent synchronization of fields

Niall Pemberton · Niall Pemberton · commit 55a86c21c296 · 2010-09-29T17:56:56.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/io/trunk@1002791 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/java/org/apache/commons/io/output/ByteArrayOutputStream.java b/src/java/org/apache/commons/io/output/ByteArrayOutputStream.java
@@ -88,7 +88,9 @@ public ByteArrayOutputStream(int size) {
             throw new IllegalArgumentException(
                 "Negative initial size: " + size);
         }
-        needNewBuffer(size);
+        synchronized (this) {
+            needNewBuffer(size);
+        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,9 @@ public ByteArrayOutputStream(int size) {`
`88`	`88`	`throw new IllegalArgumentException(`
`89`	`89`	`"Negative initial size: " + size);`
`90`	`90`	`}`
`91`		`- needNewBuffer(size);`
	`91`	`+ synchronized (this) {`
	`92`	`+ needNewBuffer(size);`
	`93`	`+ }`
`92`	`94`	`}`
`93`	`95`
`94`	`96`	`/**`