Consistently use the final modifier with local variables.

Author: garydgregory

src/main/java/org/apache/commons/io/FileUtils.java

@@ -1595,7 +1595,7 @@ public static void copyToDirectory(final Iterable<File> srcs, final File destDir
         if (srcs == null) {
             throw new NullPointerException("Sources must not be null");
         }
-        for (File src : srcs) {
+        for (final File src : srcs) {
             copyFileToDirectory(src, destDir);
         }
     }
@@ -1766,11 +1766,11 @@ private static File[] verifiedListFiles(final File directory) throws IOException
      * @throws NullPointerException if the file is {@code null}
      */
     public static boolean waitFor(final File file, final int seconds) {
-        long finishAt = System.currentTimeMillis() + (seconds * 1000L);
+        final long finishAt = System.currentTimeMillis() + (seconds * 1000L);
         boolean wasInterrupted = false;
         try {
             while (!file.exists()) {
-                long remaining = finishAt -  System.currentTimeMillis();
+                final long remaining = finishAt -  System.currentTimeMillis();
                 if (remaining < 0){
                     return false;
                 }
@@ -1849,7 +1849,7 @@ public static String readFileToString(final File file) throws IOException {
      */
     public static byte[] readFileToByteArray(final File file) throws IOException {
         try (InputStream in = openInputStream(file)) {
-            long fileLength = file.length();
+            final long fileLength = file.length();
             // file.length() may return 0 for system-dependent entities, treat 0 as unknown length - see IO-453
             return fileLength > 0 ? IOUtils.toByteArray(in, fileLength) : IOUtils.toByteArray(in);
         }

src/main/java/org/apache/commons/io/FilenameUtils.java

@@ -772,7 +772,7 @@ public static String getPrefix(final String filename) {
             failIfNullBytePresent(filename + UNIX_SEPARATOR);
             return filename + UNIX_SEPARATOR;
         }
-        String path = filename.substring(0, len);
+        final String path = filename.substring(0, len);
         failIfNullBytePresent(path);
         return path;
     }
@@ -852,7 +852,7 @@ private static String doGetPath(final String filename, final int separatorAdd) {
         if (prefix >= filename.length() || index < 0 || prefix >= endIndex) {
             return "";
         }
-        String path = filename.substring(prefix, endIndex);
+        final String path = filename.substring(prefix, endIndex);
         failIfNullBytePresent(path);
         return path;
     }
@@ -983,7 +983,7 @@ public static String getName(final String filename) {
      * @param path the path to check
      */
     private static void failIfNullBytePresent(final String path) {
-        int len = path.length();
+        final int len = path.length();
         for (int i = 0; i < len; i++) {
             if (path.charAt(i) == 0) {
                 throw new IllegalArgumentException("Null byte present in file/path name. There are no " +

src/main/java/org/apache/commons/io/IOCase.java

@@ -77,7 +77,7 @@ public enum IOCase implements Serializable {
      * @throws IllegalArgumentException if the name is invalid
      */
     public static IOCase forName(final String name) {
-        for (IOCase ioCase : IOCase.values())
+        for (final IOCase ioCase : IOCase.values())
         {
             if (ioCase.getName().equals(name))
             {

src/main/java/org/apache/commons/io/IOUtils.java

@@ -1706,7 +1706,7 @@ public static void writeChunked(final byte[] data, final OutputStream output)
             int bytes = data.length;
             int offset = 0;
             while (bytes > 0) {
-                int chunk = Math.min(bytes, DEFAULT_BUFFER_SIZE);
+                final int chunk = Math.min(bytes, DEFAULT_BUFFER_SIZE);
                 output.write(data, offset, chunk);
                 bytes -= chunk;
                 offset += chunk;
@@ -1813,7 +1813,7 @@ public static void writeChunked(final char[] data, final Writer output) throws I
             int bytes = data.length;
             int offset = 0;
             while (bytes > 0) {
-                int chunk = Math.min(bytes, DEFAULT_BUFFER_SIZE);
+                final int chunk = Math.min(bytes, DEFAULT_BUFFER_SIZE);
                 output.write(data, offset, chunk);
                 bytes -= chunk;
                 offset += chunk;

src/main/java/org/apache/commons/io/ThreadMonitor.java

@@ -122,7 +122,7 @@ public void run() {
      * @throws InterruptedException if interrupted
      */
     private static void sleep(final long ms) throws InterruptedException {
-        long finishAt = System.currentTimeMillis() + ms;
+        final long finishAt = System.currentTimeMillis() + ms;
         long remaining = ms;
         do {
             Thread.sleep(remaining);

src/main/java/org/apache/commons/io/input/BOMInputStream.java

@@ -169,7 +169,7 @@ public BOMInputStream(final InputStream delegate, final boolean include, final B
             throw new IllegalArgumentException("No BOMs specified");
         }
         this.include = include;
-        List<ByteOrderMark> list = Arrays.asList(boms);
+        final List<ByteOrderMark> list = Arrays.asList(boms);
         // Sort the BOMs to match the longest BOM first because some BOMs have the same starting two bytes.
         Collections.sort(list, ByteOrderMarkLengthComparator);
         this.boms = list;

src/main/java/org/apache/commons/io/input/ClassLoaderObjectInputStream.java

@@ -66,7 +66,7 @@ protected Class<?> resolveClass(final ObjectStreamClass objectStreamClass)
 
         try {
             return Class.forName(objectStreamClass.getName(), false, classLoader);
-        } catch (ClassNotFoundException cnfe) {
+        } catch (final ClassNotFoundException cnfe) {
             // delegate to super class loader which can resolve primitives
             return super.resolveClass(objectStreamClass);
         }

src/main/java/org/apache/commons/io/input/ObservableInputStream.java

@@ -116,7 +116,7 @@ public int read() throws IOException {
         IOException ioe = null;
         try {
             result = super.read();
-        } catch (IOException pException) {
+        } catch (final IOException pException) {
             ioe = pException;
         }
         if (ioe != null) {
@@ -135,7 +135,7 @@ public int read(final byte[] pBuffer) throws IOException {
         IOException ioe = null;
         try {
             result = super.read(pBuffer);
-        } catch (IOException pException) {
+        } catch (final IOException pException) {
             ioe = pException;
         }
         if (ioe != null) {
@@ -154,7 +154,7 @@ public int read(final byte[] pBuffer, final int pOffset, final int pLength) thro
         IOException ioe = null;
         try {
             result = super.read(pBuffer, pOffset, pLength);
-        } catch (IOException pException) {
+        } catch (final IOException pException) {
             ioe = pException;
         }
         if (ioe != null) {
@@ -176,7 +176,7 @@ public int read(final byte[] pBuffer, final int pOffset, final int pLength) thro
      *   passed down.
      */
     protected void noteDataBytes(final byte[] pBuffer, final int pOffset, final int pLength) throws IOException {
-        for (Observer observer : getObservers()) {
+        for (final Observer observer : getObservers()) {
             observer.data(pBuffer, pOffset, pLength);
         }
     }
@@ -186,7 +186,7 @@ protected void noteDataBytes(final byte[] pBuffer, final int pOffset, final int
      *   passed down.
      */
     protected void noteFinished() throws IOException {
-        for (Observer observer : getObservers()) {
+        for (final Observer observer : getObservers()) {
             observer.finished();
         }
     }
@@ -198,7 +198,7 @@ protected void noteFinished() throws IOException {
      *   passed down.
      */
     protected void noteDataByte(final int pDataByte) throws IOException {
-        for (Observer observer : getObservers()) {
+        for (final Observer observer : getObservers()) {
             observer.data(pDataByte);
         }
     }
@@ -211,7 +211,7 @@ protected void noteDataByte(final int pDataByte) throws IOException {
      *   argument.
      */
     protected void noteError(final IOException pException) throws IOException {
-        for (Observer observer : getObservers()) {
+        for (final Observer observer : getObservers()) {
             observer.error(pException);
         }
     }
@@ -221,7 +221,7 @@ protected void noteError(final IOException pException) throws IOException {
      *   passed down.
      */
     protected void noteClosed() throws IOException {
-        for (Observer observer : getObservers()) {
+        for (final Observer observer : getObservers()) {
             observer.closed();
         }
     }
@@ -238,7 +238,7 @@ public void close() throws IOException {
         IOException ioe = null;
         try {
             super.close();
-        } catch (IOException e) {
+        } catch (final IOException e) {
             ioe = e;
         }
         if (ioe == null) {

src/main/java/org/apache/commons/io/input/Tailer.java

@@ -439,7 +439,7 @@ public void run() {
                         // Finish scanning the old file and then we'll start with the new one
                         try {
                             readLines(save);
-                        }  catch (IOException ioe) {
+                        }  catch (final IOException ioe) {
                             listener.handle(ioe);
                         }
                         position = 0;

src/main/java/org/apache/commons/io/input/UnixLineEndingInputStream.java

@@ -69,12 +69,12 @@ private int readWithUpdate() throws IOException {
      */
     @Override
     public int read() throws IOException {
-        boolean previousWasSlashR = slashRSeen;
+        final boolean previousWasSlashR = slashRSeen;
         if ( eofSeen ) {
             return eofGame(previousWasSlashR);
         }
         else {
-            int target = readWithUpdate();
+            final int target = readWithUpdate();
             if ( eofSeen ) {
                 return eofGame(previousWasSlashR);
             }