Skip to content

Commit 62933fa

Browse files
committed
Improved test: Test listFiles with extensions = null
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/io/trunk@140447 13f79535-47bb-0310-9956-ffa450edef68
1 parent 69ec6e2 commit 62933fa

1 file changed

Lines changed: 16 additions & 2 deletions

File tree

src/test/org/apache/commons/io/FileUtilsListFilesTestCase.java

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ protected void setUp() throws Exception {
3232
dir.mkdirs();
3333
File file = new File(dir, "dummy-build.xml");
3434
FileUtils.touch(file);
35+
file = new File(dir, "README");
36+
FileUtils.touch(file);
3537

3638
dir = new File(dir, "subdir1");
3739
dir.mkdirs();
@@ -74,16 +76,28 @@ private Collection filesToFilenames(Collection files) {
7476
}
7577

7678
public void testListFilesByExtension() throws Exception {
77-
String[] extensions = {"xml", "txt"};
79+
final String[] extensions = {"xml", "txt"};
80+
7881
Collection files = FileUtils.listFiles(getLocalTestDirectory(), extensions, false);
7982
assertEquals(1, files.size());
8083
Collection filenames = filesToFilenames(files);
8184
assertTrue(filenames.contains("dummy-build.xml"));
85+
assertFalse(filenames.contains("README"));
86+
assertFalse(filenames.contains("dummy-file.txt"));
87+
8288
files = FileUtils.listFiles(getLocalTestDirectory(), extensions, true);
8389
filenames = filesToFilenames(files);
8490
assertEquals(4, filenames.size());
8591
assertTrue(filenames.contains("dummy-file.txt"));
86-
assertFalse(filenames.contains("dumy-index.html"));
92+
assertFalse(filenames.contains("dummy-index.html"));
93+
94+
files = FileUtils.listFiles(getLocalTestDirectory(), null, false);
95+
assertEquals(2, files.size());
96+
filenames = filesToFilenames(files);
97+
assertTrue(filenames.contains("dummy-build.xml"));
98+
assertTrue(filenames.contains("README"));
99+
assertFalse(filenames.contains("dummy-file.txt"));
100+
87101
}
88102

89103
public void testListFiles() throws Exception {

0 commit comments

Comments
 (0)