[IO-329] FileUtils.writeLines uses unbuffered IO.

garydgregory · garydgregory · commit 67bcaa51f426 · 2012-05-28T13:42:40.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/io/trunk@1343253 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -47,6 +47,9 @@ The <action> type attribute can be add,update,fix,remove.
   <body>
     <!-- The release date is the date RC is cut -->
     <release version="2.4" date="2012-TDB-TDB" description="">
+      <action issue="IO-329" dev="ggregory" type="fix" due-to="tivv">
+        FileUtils.writeLines uses unbuffered IO.
+      </action>            
       <action issue="IO-327" dev="ggregory" type="add" due-to="ggregory">
         Add byteCountToDisplaySize(BigInteger).
       </action>            
diff --git a/src/main/java/org/apache/commons/io/FileUtils.java b/src/main/java/org/apache/commons/io/FileUtils.java
@@ -16,6 +16,7 @@
  */
 package org.apache.commons.io;
 
+import java.io.BufferedOutputStream;
 import java.io.File;
 import java.io.FileFilter;
 import java.io.FileInputStream;
@@ -2201,11 +2202,11 @@ public static void writeLines(File file, String encoding, Collection<?> lines, S
      * @since 2.1
      */
     public static void writeLines(File file, String encoding, Collection<?> lines, String lineEnding, boolean append)
-        throws IOException {
-        OutputStream out = null;
+            throws IOException {
+        FileOutputStream out = null;
         try {
             out = openOutputStream(file, append);
-            IOUtils.writeLines(lines, lineEnding, out, encoding);
+            IOUtils.writeLines(lines, lineEnding, new BufferedOutputStream(out), encoding);
             out.close(); // don't swallow close Exception if copy completes normally
         } finally {
             IOUtils.closeQuietly(out);
