Fix PMD UnnecessaryFullyQualifiedName and friends

- Fix PMD 7.1.0 issues

Author: garydgregory

src/changes/changes.xml

@@ -55,6 +55,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action dev="ggregory" type="fix"                due-to="Gary Gregory">FileUtils.lastModifiedFileTime(File) calls Objects.requireNonNull() on the wrong object.</action>
       <action dev="ggregory" type="fix"                due-to="Gary Gregory">PathUtils.deleteOnExit(Path) calls Objects.requireNonNull() on the wrong object.</action>
       <action dev="ggregory" type="fix"                due-to="Gary Gregory">Deprecate LineIterator.nextLine() in favor of next().</action>
+      <action dev="ggregory" type="fix"                due-to="Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName.</action>
       <!-- UPDATE -->
       <action dev="ggregory" type="update"             due-to="Dependabot">Bump tests commons.bytebuddy.version from 1.14.13 to 1.14.15 #615, #621.</action>
       <action dev="ggregory" type="update"             due-to="Dependabot">Bump tests commons-codec:commons-codec from 1.16.1 to 1.17.0.</action>

src/conf/maven-pmd-plugin.xml

@@ -65,7 +65,12 @@ under the License.
     <rule ref="category/java/errorprone.xml/CheckSkipResult" />
     <rule ref="category/java/errorprone.xml/ClassCastExceptionWithToArray" />
     <rule ref="category/java/errorprone.xml/DontUseFloatTypeForLoopIndices" />
-    <rule ref="category/java/errorprone.xml/EmptyCatchBlock" />
+    <rule ref="category/java/errorprone.xml/EmptyCatchBlock">
+      <properties>
+        <property name="allowCommentedBlocks" value="true" />
+        <property name="allowExceptionNameRegex" value="^(ignored|expected)$" />
+      </properties>
+    </rule>
     <rule ref="category/java/errorprone.xml/JumbledIncrementer" />
     <rule ref="category/java/errorprone.xml/MisplacedNullCheck" />
     <rule ref="category/java/errorprone.xml/OverrideBothEqualsAndHashcode" />

src/main/java/org/apache/commons/io/FileCleaningTracker.java

@@ -54,7 +54,7 @@ private final class Reaper extends Thread {
         /** Constructs a new Reaper */
         Reaper() {
             super("File Reaper");
-            setPriority(Thread.MAX_PRIORITY);
+            setPriority(MAX_PRIORITY);
             setDaemon(true);
         }
 

src/main/java/org/apache/commons/io/FileUtils.java

@@ -2485,7 +2485,7 @@ public static void moveFile(final File srcFile, final File destFile, final CopyO
             // Don't interfere with file date on move, handled by StandardCopyOption.COPY_ATTRIBUTES
             copyFile(srcFile, destFile, false, copyOptions);
             if (!srcFile.delete()) {
-                FileUtils.deleteQuietly(destFile);
+                deleteQuietly(destFile);
                 throw new IOException("Failed to delete original file '" + srcFile + "' after copy to '" + destFile + "'");
             }
         }

src/main/java/org/apache/commons/io/IOCase.java

@@ -76,7 +76,7 @@ public enum IOCase {
      * @throws IllegalArgumentException if the name is invalid
      */
     public static IOCase forName(final String name) {
-        return Stream.of(IOCase.values()).filter(ioCase -> ioCase.getName().equals(name)).findFirst()
+        return Stream.of(values()).filter(ioCase -> ioCase.getName().equals(name)).findFirst()
                 .orElseThrow(() -> new IllegalArgumentException("Illegal IOCase name: " + name));
     }
 

src/main/java/org/apache/commons/io/IOUtils.java

@@ -1104,7 +1104,7 @@ public static int copy(final InputStream inputStream, final OutputStream outputS
      */
     public static long copy(final InputStream inputStream, final OutputStream outputStream, final int bufferSize)
             throws IOException {
-        return copyLarge(inputStream, outputStream, IOUtils.byteArray(bufferSize));
+        return copyLarge(inputStream, outputStream, byteArray(bufferSize));
     }
 
     /**

src/main/java/org/apache/commons/io/ThreadMonitor.java

@@ -102,7 +102,7 @@ public void run() {
         try {
             ThreadUtils.sleep(timeout);
             thread.interrupt();
-        } catch (final InterruptedException e) {
+        } catch (final InterruptedException ignored) {
             // timeout not reached
         }
     }

src/main/java/org/apache/commons/io/file/Counters.java

@@ -173,7 +173,7 @@ private final static class BigIntegerPathCounters extends AbstractPathCounters {
          * Constructs a new initialized instance.
          */
         protected BigIntegerPathCounters() {
-            super(Counters.bigIntegerCounter(), Counters.bigIntegerCounter(), Counters.bigIntegerCounter());
+            super(bigIntegerCounter(), bigIntegerCounter(), bigIntegerCounter());
         }
 
     }
@@ -295,7 +295,7 @@ private final static class LongPathCounters extends AbstractPathCounters {
          * Constructs a new initialized instance.
          */
         protected LongPathCounters() {
-            super(Counters.longCounter(), Counters.longCounter(), Counters.longCounter());
+            super(longCounter(), longCounter(), longCounter());
         }
 
     }
@@ -356,7 +356,7 @@ private static final class NoopPathCounters extends AbstractPathCounters {
          * Constructs a new initialized instance.
          */
         private NoopPathCounters() {
-            super(Counters.noopCounter(), Counters.noopCounter(), Counters.noopCounter());
+            super(noopCounter(), noopCounter(), noopCounter());
         }
 
     }

src/main/java/org/apache/commons/io/file/PathUtils.java

@@ -498,7 +498,7 @@ public static PathCounters deleteDirectory(final Path directory) throws IOExcept
      * @since 2.8.0
      */
     public static PathCounters deleteDirectory(final Path directory, final DeleteOption... deleteOptions) throws IOException {
-        final LinkOption[] linkOptions = PathUtils.noFollowLinkOptionArray();
+        final LinkOption[] linkOptions = noFollowLinkOptionArray();
         // POSIX ops will noop on non-POSIX.
         return withPosixFileAttributes(getParent(directory), linkOptions, overrideReadOnly(deleteOptions),
                 pfa -> visitFileTree(new DeletingPathVisitor(Counters.longPathCounters(), linkOptions, deleteOptions), directory).getPathCounters());

src/main/java/org/apache/commons/io/file/StandardDeleteOption.java

@@ -45,7 +45,7 @@ public static boolean overrideReadOnly(final DeleteOption[] options) {
         if (IOUtils.length(options) == 0) {
             return false;
         }
-        return Stream.of(options).anyMatch(e -> StandardDeleteOption.OVERRIDE_READ_ONLY == e);
+        return Stream.of(options).anyMatch(e -> OVERRIDE_READ_ONLY == e);
     }
 
 }