[IO-507] Add a ByteOrderParser class.

Author: britter

src/changes/changes.xml

@@ -114,7 +114,7 @@ The <action> type attribute can be add,update,fix,remove.
         Add infinite circular input stream
       </action>
       <action issue="IO-507" dev="ggregory" type="add">
-        Add a ByteOrderUtils class.
+        Add a ByteOrderParser class.
       </action>
       <action issue="IO-518" dev="jochen" type="add">
         Add ObservableInputStream

…rg/apache/commons/io/ByteOrderUtils.java …g/apache/commons/io/ByteOrderParser.javasrc/main/java/org/apache/commons/io/ByteOrderUtils.java renamed to src/main/java/org/apache/commons/io/ByteOrderParser.java src/main/java/org/apache/commons/io/ByteOrderUtils.java renamed to src/main/java/org/apache/commons/io/ByteOrderParser.java

@@ -25,38 +25,26 @@
  *
  * @since 2.6
  */
-public final class ByteOrderUtils {
-
-    private static final Locale ComparisonLocale = Locale.ROOT;
-
-    /**
-     * Big endian.
-     */
-    public static final String BIG_ENDIAN = "Big";
-
-    /**
-     * Little endian.
-     */
-    public static final String LITTLE_ENDIAN = "Little";
+public final class ByteOrderParser {
 
     /**
      * ByteOrderUtils is a static utility class, so prevent construction with a private constructor.
      */
-    private ByteOrderUtils() {
+    private ByteOrderParser() {
     }
 
     /**
      * Parses the String argument as a {@link ByteOrder}, ignoring case.
      * <p>
-     * Returns {@code ByteOrder.LITTLE_ENDIAN} if the given value is {@code "little"} or {@code "LITTLE_ENDIAN"}.
+     * Returns {@code ByteOrder.LITTLE_ENDIAN} if the given value is {@code "LITTLE_ENDIAN"}.
      * </p>
      * <p>
-     * Returns {@code ByteOrder.BIG_ENDIAN} if the given value is {@code "big"} or {@code "BIG_ENDIAN"}.
+     * Returns {@code ByteOrder.BIG_ENDIAN} if the given value is {@code "BIG_ENDIAN"}.
      * </p>
      * Examples:
      * <ul>
-     * <li>{@code ByteOrderUtils.parseByteOrder("little")} returns {@code ByteOrder.LITTLE_ENDIAN}</li>
-     * <li>{@code ByteOrderUtils.parseByteOrder("big")} returns {@code ByteOrder.BIG_ENDIAN}</li>
+     * <li>{@code ByteOrderParser.parseByteOrder("LITTLE_ENDIAN")} returns {@code ByteOrder.LITTLE_ENDIAN}</li>
+     * <li>{@code ByteOrderParser.parseByteOrder("BIG_ENDIAN")} returns {@code ByteOrder.BIG_ENDIAN}</li>
      * </ul>
      *
      * @param value
@@ -66,17 +54,14 @@ private ByteOrderUtils() {
      *             if the {@code String} containing the ByteOrder representation to be parsed is unknown.
      */
     public static ByteOrder parseByteOrder(final String value) {
-        final String valueUp = value.toUpperCase(ComparisonLocale);
-        final String bigEndianUp = BIG_ENDIAN.toUpperCase(ComparisonLocale);
-        final String littleEndianUp = LITTLE_ENDIAN.toUpperCase(ComparisonLocale);
-        if (bigEndianUp.equals(valueUp) || ByteOrder.BIG_ENDIAN.toString().equals(valueUp)) {
+        if (ByteOrder.BIG_ENDIAN.toString().equals(value)) {
             return ByteOrder.BIG_ENDIAN;
         }
-        if (littleEndianUp.equals(valueUp) || ByteOrder.LITTLE_ENDIAN.toString().equals(valueUp)) {
+        if (ByteOrder.LITTLE_ENDIAN.toString().equals(value)) {
             return ByteOrder.LITTLE_ENDIAN;
         }
-        throw new IllegalArgumentException("Unsupported byte order setting: " + value + ", expeced one of " + ByteOrder.LITTLE_ENDIAN + ", " +
-                LITTLE_ENDIAN + ", " + ByteOrder.BIG_ENDIAN + ", " + bigEndianUp);
+        throw new IllegalArgumentException("Unsupported byte order setting: " + value + ", expeced one of " + ByteOrder.LITTLE_ENDIAN +
+                 ", " + ByteOrder.BIG_ENDIAN);
     }
 
 }

…pache/commons/io/ByteOrderUtilsTest.java …ache/commons/io/ByteOrderParserTest.javasrc/test/java/org/apache/commons/io/ByteOrderUtilsTest.java renamed to src/test/java/org/apache/commons/io/ByteOrderParserTest.java src/test/java/org/apache/commons/io/ByteOrderUtilsTest.java renamed to src/test/java/org/apache/commons/io/ByteOrderParserTest.java

@@ -21,23 +21,24 @@
 import org.junit.Assert;
 import org.junit.Test;
 
-public class ByteOrderUtilsTest {
+public class ByteOrderParserTest {
 
     private ByteOrder parseByteOrder(final String value) {
-        return ByteOrderUtils.parseByteOrder(value);
+        return ByteOrderParser.parseByteOrder(value);
     }
 
     @Test
     public void testParseBig() {
-        Assert.assertEquals(ByteOrder.BIG_ENDIAN, parseByteOrder("big"));
-        Assert.assertEquals(ByteOrder.BIG_ENDIAN, parseByteOrder("Big"));
-        Assert.assertEquals(ByteOrder.BIG_ENDIAN, parseByteOrder("BIG"));
+        Assert.assertEquals(ByteOrder.BIG_ENDIAN, parseByteOrder("BIG_ENDIAN"));
     }
 
     @Test
     public void testParseLittle() {
-        Assert.assertEquals(ByteOrder.LITTLE_ENDIAN, parseByteOrder("little"));
-        Assert.assertEquals(ByteOrder.LITTLE_ENDIAN, parseByteOrder("Little"));
-        Assert.assertEquals(ByteOrder.LITTLE_ENDIAN, parseByteOrder("LITTLE"));
+        Assert.assertEquals(ByteOrder.LITTLE_ENDIAN, parseByteOrder("LITTLE_ENDIAN"));
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testThrowsException() throws Exception {
+        parseByteOrder("some value");
     }
 }