[IO-791] Regression in FileUtils.touch - no longer creates parent

garydgregory · garydgregory · commit 7752088fee7e · 2023-05-17T17:29:45.000-04:00
directories
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -47,6 +47,12 @@ The <action> type attribute can be add,update,fix,remove.
   </properties>
 
   <body>
+    <release version="2.12.1" date="2023-MM-DD" description="Java 8 required.">
+      <!-- FIX -->
+      <action issue="IO-791" dev="ggregory" type="fix" due-to="Chad Wilson, Gary Gregory">
+        Regression in FileUtils.touch - no longer creates parent directories.
+      </action>
+    </release>
     <release version="2.12.0" date="2023-05-13" description="Java 8 required.">
       <!-- FIX -->
       <action issue="IO-697" dev="kinow" type="fix" due-to="otter606">
diff --git a/src/main/java/org/apache/commons/io/file/PathUtils.java b/src/main/java/org/apache/commons/io/file/PathUtils.java
@@ -1599,7 +1599,7 @@ static Set<FileVisitOption> toFileVisitOptionSet(final FileVisitOption... fileVi
 
     /**
      * Implements behavior similar to the Unix "touch" utility. Creates a new file with size 0, or, if the file exists, just
-     * updates the file's modified time.
+     * updates the file's modified time. this method creates parent directories if they do not exist.
      *
      * @param file the file to touch.
      * @return The given file.
@@ -1610,6 +1610,7 @@ static Set<FileVisitOption> toFileVisitOptionSet(final FileVisitOption... fileVi
     public static Path touch(final Path file) throws IOException {
         Objects.requireNonNull(file, "file");
         if (!Files.exists(file)) {
+            createParentDirectories(file);
             Files.createFile(file);
         } else {
             FileTimes.setLastModifiedTime(file);
diff --git a/src/test/java/org/apache/commons/io/FileUtilsTest.java b/src/test/java/org/apache/commons/io/FileUtilsTest.java
@@ -2731,6 +2731,19 @@ public void testTouch() throws IOException {
         assertTrue(getLastModifiedMillis(file) <= nowMillis + delta, "FileUtils.touch() changed lastModified to less than now+3s");
     }
 
+    @Test
+    public void testTouchDirDoesNotExist() throws Exception {
+        final File file = new File("target/does-not-exist", "touchme.txt");
+        final File parentDir = file.getParentFile();
+        file.delete();
+        parentDir.delete();
+        assertFalse(parentDir.exists());
+        assertFalse(file.exists());
+        FileUtils.touch(file);
+        assertTrue(parentDir.exists());
+        assertTrue(file.exists());
+    }
+
     @Test
     public void testToURLs1() throws Exception {
         final File[] files = {
