CharSequenceReader.skip should return 0 instead of EOF on stream end (#123)

Author: robtimus

src/main/java/org/apache/commons/io/input/CharSequenceReader.java

@@ -272,7 +272,7 @@ public long skip(final long n) {
                     "Number of characters to skip is less than zero: " + n);
         }
         if (idx >= end()) {
-            return EOF;
+            return 0;
         }
         final int dest = (int)Math.min(end(), idx + n);
         final int count = dest - idx;

src/test/java/org/apache/commons/io/input/CharSequenceReaderTest.java

@@ -89,23 +89,23 @@ public void testSkip() throws IOException {
         final Reader reader = new CharSequenceReader("FooBar");
         assertEquals(3, reader.skip(3));
         checkRead(reader, "Bar");
-        assertEquals(-1, reader.skip(3));
+        assertEquals(0, reader.skip(3));
         reader.reset();
         assertEquals(2, reader.skip(2));
         assertEquals(4, reader.skip(10));
-        assertEquals(-1, reader.skip(1));
+        assertEquals(0, reader.skip(1));
         reader.close();
         assertEquals(6, reader.skip(20));
         assertEquals(-1, reader.read());
 
         final Reader subReader = new CharSequenceReader("xFooBarx", 1, 7);
         assertEquals(3, subReader.skip(3));
         checkRead(subReader, "Bar");
-        assertEquals(-1, subReader.skip(3));
+        assertEquals(0, subReader.skip(3));
         subReader.reset();
         assertEquals(2, subReader.skip(2));
         assertEquals(4, subReader.skip(10));
-        assertEquals(-1, subReader.skip(1));
+        assertEquals(0, subReader.skip(1));
         subReader.close();
         assertEquals(6, subReader.skip(20));
         assertEquals(-1, subReader.read());